)]}'
{
  "commit": "e587e37eee3f8f9f1e28624d36f962d6b8de08bf",
  "tree": "59fa5860051b06475e95eba1a06bf143dd79dba6",
  "parents": [
    "df870ed7fa51110edb872beb3357a44d20e1ce56"
  ],
  "author": {
    "name": "Moreno Ambrosin",
    "email": "ambrosin@google.com",
    "time": "Wed Oct 28 15:25:32 2026 -0700"
  },
  "committer": {
    "name": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Oct 28 15:41:50 2026 -0700"
  },
  "message": "crypto/x509: Make GENERAL_NAME_cmp a total order.\n\nGENERAL_NAME_cmp returned -1 in both directions when the name types\ndiffered, as did ASN1_TYPE_cmp (used for otherName values), and\nedipartyname_cmp when the nameAssigner fields differed. This made them\nunsuitable for sorting. Instead, order by type first, then by the\ntype-specific contents, with an absent nameAssigner sorting first.\nWhich non-NULL inputs compare equal is unchanged.\n\nASN1_TYPE_cmp now sorts NULL before non-NULL values, so two NULLs\ncompare equal. This lets X509_ALGOR_cmp drop its special case and also\nbecome a total order, with an absent parameter sorting first. Which\ninputs compare equal is unchanged.\n\nThe one remaining exception is X509_NAME_cmp\u0027s -2 return when a name\ncannot be serialized, which cannot happen for unmodified parsed names.\n\nWhile I\u0027m here, remove NULL checks in GENERAL_NAME_cmp and othername_cmp\nthat cannot be hit.\n\nUpdate-Note: ASN1_TYPE_cmp and X509_ALGOR_cmp now return a consistent\nordering. Callers that only compare the result against zero are\nunaffected, except that ASN1_TYPE_cmp(NULL, NULL) now returns zero\ninstead of -1. Callers that checked for a specific non-zero value, such\nas -1, should compare against zero instead.\n\nBug: 565047760\nChange-Id: I7d8f98c25fe967afbe6ec518b4012a52b1c5e3ba\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/104768\nReviewed-by: David Benjamin \u003cdavidben@google.com\u003e\nCommit-Queue: Moreno Ambrosin \u003cambrosin@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "35e0534e0a310233a34c257b2d027c1b1013a09c",
      "old_mode": 33188,
      "old_path": "crypto/asn1/a_type.cc",
      "new_id": "9a8d762f3d932e3618c911e67156dde1805029af",
      "new_mode": 33188,
      "new_path": "crypto/asn1/a_type.cc"
    },
    {
      "type": "modify",
      "old_id": "aa1e3bd307dffb51c25437c18c96d069164eea4c",
      "old_mode": 33188,
      "old_path": "crypto/asn1/asn1_test.cc",
      "new_id": "e7466226d223d12afae8eea5106b1cfd432515d3",
      "new_mode": 33188,
      "new_path": "crypto/asn1/asn1_test.cc"
    },
    {
      "type": "modify",
      "old_id": "ab44a62327e5eae2b9bf23fdb7b432b46e720ed0",
      "old_mode": 33188,
      "old_path": "crypto/x509/internal.h",
      "new_id": "eb35b9acd9af07323c024426f5312fa7cd141f4f",
      "new_mode": 33188,
      "new_path": "crypto/x509/internal.h"
    },
    {
      "type": "modify",
      "old_id": "ac839d5b049f96c394ee97edecaecd1ee161cf8c",
      "old_mode": 33188,
      "old_path": "crypto/x509/v3_genn.cc",
      "new_id": "1f0c9de05ab20c2421e65af62cf2659fd6f3b9c0",
      "new_mode": 33188,
      "new_path": "crypto/x509/v3_genn.cc"
    },
    {
      "type": "modify",
      "old_id": "e2e669dbdaed4731c8d3c34c132ebe059c278998",
      "old_mode": 33188,
      "old_path": "crypto/x509/x509_test.cc",
      "new_id": "b3280fe54beccaee2832c2cc34ce655f03cdcd5e",
      "new_mode": 33188,
      "new_path": "crypto/x509/x509_test.cc"
    },
    {
      "type": "modify",
      "old_id": "b4591e5f337fd55af5057cc02221481e252a4021",
      "old_mode": 33188,
      "old_path": "crypto/x509/x_algor.cc",
      "new_id": "93926c302a2063ad97cc4f4ce98a22726dce9e4b",
      "new_mode": 33188,
      "new_path": "crypto/x509/x_algor.cc"
    },
    {
      "type": "modify",
      "old_id": "2882a25b1f87de397a57cb6df2eb2c248879d562",
      "old_mode": 33188,
      "old_path": "include/openssl/asn1.h",
      "new_id": "19f262964f84d16ea8c87ab67b500cdea6a3ce07",
      "new_mode": 33188,
      "new_path": "include/openssl/asn1.h"
    },
    {
      "type": "modify",
      "old_id": "cc2459a099a99d01a03d510178dddb6544a226c6",
      "old_mode": 33188,
      "old_path": "include/openssl/x509.h",
      "new_id": "5378ec5026d43f195b3c24c84caf330a8c82e3d1",
      "new_mode": 33188,
      "new_path": "include/openssl/x509.h"
    }
  ]
}
