)]}'
{
  "commit": "e0bb21bc8f8aafe67056242bc7f5ab2e22b14b8e",
  "tree": "2c85b3b45d6b66a45071273a6e508d987f6365f6",
  "parents": [
    "e5c86b740520111558eaaca59ec1692d5fa9bb30"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue Nov 15 17:44:23 2022 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Nov 22 23:30:08 2022 +0000"
  },
  "message": "Update x86_64-mont5.pl and RSAZ comments a bit.\n\nBack in https://boringssl-review.googlesource.com/c/boringssl/+/33268, I\nwrote that I had no idea what the mont5 assembly was doing. In\npreparation for fixing up some comments around\nBN_mod_exp_mont_consttime, I wanted to understand whether we were still\nmaking assumptions about cache lines.\n\nHappily, for the mont5 code, the answer is no, we are not. We just make\na bunch of masks and apply them in the natural way. But we do require\n16-byte alignment on the table, because we use movdqa to read out of it.\n\nI didn\u0027t look as closely at RSAZ, but I believe it too is fine. It\nfairly quickly tosses $power into an XMM register and builds up masks,\nrather than incorporating it into address computations.\n\n(Both scatter5 functions incorporate it into the address, but that\u0027s\npart of table building, where the index is public. I\u0027ve updated the\ncomments to note when the index is secret or public.)\n\nThere is one reference to cache lines in the comments of mont5.pl, in\ncomputing $N. However, $N has been unused since\nhttps://boringssl-review.googlesource.com/c/boringssl/+/7244. (There are\nreferences to $N[0] and friends, but those refer to @N, which is a\ncompletely unrelated variable.) Remove it.\n\nChange-Id: I1fac0660dffcd1380572029de2e5baece60cddf6\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/55225\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\nCommit-Queue: Bob Beck \u003cbbe@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "012e7aa509a3c2e9aa6f1a122e3fcc8290f0fe4c",
      "old_mode": 33261,
      "old_path": "crypto/fipsmodule/bn/asm/x86_64-mont5.pl",
      "new_id": "6c596e3f030ec00b65710e8e14fe00bc217d3909",
      "new_mode": 33261,
      "new_path": "crypto/fipsmodule/bn/asm/x86_64-mont5.pl"
    },
    {
      "type": "modify",
      "old_id": "ec87dd890d71319159f9d057273283bd4e71da7f",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/bn/internal.h",
      "new_id": "9329ce7aaa42f074a517dd0cd42da02466981285",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/bn/internal.h"
    },
    {
      "type": "modify",
      "old_id": "bc7a439e75c6002895ca8017db654537ba7c6aae",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/bn/rsaz_exp.h",
      "new_id": "67f1cab5c7e02bf33eb8b37759f03390987df291",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/bn/rsaz_exp.h"
    }
  ]
}