| commit | df13691019be62da728e0c63463fe51bb5d7c29d | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Fri Jul 14 17:04:13 2023 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jul 19 18:25:13 2023 +0000 |
| tree | e1e3d1ccbc0cecc0d4a0c071a7d18b8463687d4f | |
| parent | 2b5d6ba0341588e4bbd53d6055118e5472657b49 [diff] |
Tidy up error handling for sockets vs fds On Windows, sockets and fds are different, so we need to be a little carefully. The fd functions (which are really a userspace construct inside the libc) report errors by writing to errno: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/read?view=msvc-170 While the socket functions (which are really thin wrappers over Windows HANDLEs) use WSAGetLastError: https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-recv https://learn.microsoft.com/en-us/windows/win32/winsock/error-codes-errno-h-errno-and-wsagetlasterror-2 Moreover, the error values are different, so we shouldn't mix them together: https://learn.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2 https://learn.microsoft.com/en-us/cpp/c-runtime-library/errno-constants?view=msvc-170 Finally, by borrowing OpenSSL's distinct OPENSSL_NO_SOCK and OPENSSL_NO_POSIX_IO options, we arguably should account for all combinations of one or the other being missing. (Ugh.) To account for that, I've moved bio_fd_should_retry into its own file that isn't conditioned on anything. It only depends on <errno.h>, which is part of the C standard library, and used elsewhere already. Change-Id: I0519d7d68c32062e1220ffca0ab57a9cac9f7e5f Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/61729 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Bob Beck <bbe@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: