Always enable X509_V_FLAG_TRUSTED_FIRST

No one seems to ever disable it. This means we can unwind the alt-chains
logic, as it's never used as a result.

As discussed in
https://boringssl-review.googlesource.com/c/boringssl/+/49746, neither
mode is really correct. An ideal implementation would be a backtracking
path builder. But the particular implementation of backtracking in
alt-chains is both insufficient and particularly messy. Simplify this
for now and go from there.

Update-Note: X509_V_FLAG_TRUSTED_FIRST is now always enabled. (It was
previously a default.) Passing it to X509_VERIFY_PARAM_clear_flags now
does nothing. Running tests suggests no one is relying on this. This
means X509_V_FLAG_NO_ALT_CHAINS is now also a no-op because it does
nothing when X509_V_FLAG_TRUSTED_FIRST is enabled.

Bug: 544895602
Change-Id: I0b6519f705de2abacea2b6041ae855d59286b631
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/100787
Auto-Submit: David Benjamin <davidben@google.com>
Reviewed-by: Rudolf Polzer <rpolzer@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
5 files changed
tree: 1b98e1fb3a5b0d1f3b016c681d955e695019e518
  1. .agents/
  2. .bcr/
  3. .github/
  4. agents/
  5. bench/
  6. cmake/
  7. crypto/
  8. decrepit/
  9. docs/
  10. fuzz/
  11. gen/
  12. include/
  13. infra/
  14. pki/
  15. rust/
  16. ssl/
  17. third_party/
  18. tool/
  19. util/
  20. .bazelignore
  21. .bazelrc
  22. .bazelversion
  23. .clang-format
  24. .clang-format-ignore
  25. .clangd
  26. .gitattributes
  27. .gitignore
  28. API-CONVENTIONS.md
  29. AUTHORS
  30. BREAKING-CHANGES.md
  31. BUILD.bazel
  32. build.json
  33. BUILDING.md
  34. CMakeLists.txt
  35. codereview.settings
  36. CONTRIBUTING.md
  37. FUZZING.md
  38. go.mod
  39. go.sum
  40. INCORPORATING.md
  41. LICENSE
  42. MODULE.bazel
  43. MODULE.bazel.lock
  44. PORTING.md
  45. PRESUBMIT.py
  46. PrivacyInfo.xcprivacy
  47. README.md
  48. SANDBOXING.md
  49. SECURITY.md
  50. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: