Tolerate feof returning arbitrary non-zero values feof apparently does not promise EOF returns 1, just a non-zero value. See [0]. We very much do not care about the impacted platform, but it is probably prudent to handle this, in case some platform we do care about uses this leeway. While I'm here, add a test for EOF in file BIOs. In writing this test, I noticed that BIO_reset's return value convention, like BIO_seek, is completely inconsistent. Document the problem for now. (OpenSSL's documentation[1] also mentions this, though they seem to have missed that fds are also impacted.) [0] https://github.com/openssl/openssl/pull/30395 [1] https://docs.openssl.org/master/man3/BIO_ctrl/#description:~:text=%C2%B6-,BIO_reset()%20normally%20returns%201%20for%20success%20and%20%3C%3D0%20for%20failure.%20File%20BIOs%20are%20an%20exception%2C%20they%20return%200%20for%20success%20and%20%2D1%20for%20failure.,-BIO_seek()%20and%20BIO_tell Change-Id: I2df1925b157bb34897174143d74ca9e5e86a673c Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/90888 Reviewed-by: Lily Chen <chlily@google.com> Commit-Queue: Lily Chen <chlily@google.com> Auto-Submit: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: