| commit | dd935202c9e41db49bfa1e7082d8f0db5788951a | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Wed Jun 13 15:36:06 2018 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Wed Jun 13 19:58:24 2018 +0000 |
| tree | 70ee6d71a8e5d9ded14c7d6612214be3298ec15a | |
| parent | 6ff2ba80b758025fdb137d9357dcbba0a9c04dbf [diff] |
Zero-initialize tmp in ec_GFp_simple_mul_single. Although the original value of tmp does not matter, the selects ultimately do bit operations on the uninitialized values and thus depend on them behaving like *some* consistent concrete value. The C spec appears to allow uninitialized values to resolve to trap representations, which means this isn't quite valid.. (If I'm reading it wrong and the compiler must behave as if there were a consistent value in there, it's probably fine, but there's no sense in risking compiler bugs on a subtle corner of things.) Change-Id: Id4547b0ec702414b387e906c4de55595e6214ddb Reviewed-on: https://boringssl-review.googlesource.com/29124 Commit-Queue: Steven Valdez <svaldez@google.com> Reviewed-by: Steven Valdez <svaldez@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: