tree 03d0c781ac950bbe440a6b1127f5353ea9174cd2
parent 60be02762578c0e5be04171330329af051bc9f44
author David Benjamin <davidben@chromium.org> 1445187032 -0400
committer Adam Langley <alangley@gmail.com> 1445886014 +0000

Remove all the logic around custom session IDs and retrying on collisions.

A random 32-byte (so 256-bit) session ID is never going to collide with
an existing one. (And, if it does, SSL_CTX_add_session does account for
this, so the server won't explode. Just attempting to resume some
session will fail.)

That logic didn't completely work anyway as it didn't account for
external session caches or multiple connections picking the same ID in
parallel (generation and insertion happen at different times) or
multiple servers sharing one cache. In theory one could fix this by
passing in a sufficiently clever generate_session_id, but no one does
that.

I found no callers of these functions, so just remove them altogether.

Change-Id: I8500c592cf4676de6d7194d611b99e9e76f150a7
Reviewed-on: https://boringssl-review.googlesource.com/6318
Reviewed-by: Adam Langley <alangley@gmail.com>