)]}' { "commit": "dc2aea2231c2a89cfcbd8859f6a22657b393f480", "tree": "03d0c781ac950bbe440a6b1127f5353ea9174cd2", "parents": [ "60be02762578c0e5be04171330329af051bc9f44" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Sun Oct 18 12:50:32 2015 -0400" }, "committer": { "name": "Adam Langley", "email": "alangley@gmail.com", "time": "Mon Oct 26 19:00:14 2015 +0000" }, "message": "Remove all the logic around custom session IDs and retrying on collisions.\n\nA random 32-byte (so 256-bit) session ID is never going to collide with\nan existing one. (And, if it does, SSL_CTX_add_session does account for\nthis, so the server won\u0027t explode. Just attempting to resume some\nsession will fail.)\n\nThat logic didn\u0027t completely work anyway as it didn\u0027t account for\nexternal session caches or multiple connections picking the same ID in\nparallel (generation and insertion happen at different times) or\nmultiple servers sharing one cache. In theory one could fix this by\npassing in a sufficiently clever generate_session_id, but no one does\nthat.\n\nI found no callers of these functions, so just remove them altogether.\n\nChange-Id: I8500c592cf4676de6d7194d611b99e9e76f150a7\nReviewed-on: https://boringssl-review.googlesource.com/6318\nReviewed-by: Adam Langley \u003calangley@gmail.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "c2dd3363925faa2c53b9a1fc4b4b4b1cead10395", "old_mode": 33188, "old_path": "include/openssl/ssl.h", "new_id": "0b98b1117f7f6397a01d5da714c482cae65067e3", "new_mode": 33188, "new_path": "include/openssl/ssl.h" }, { "type": "modify", "old_id": "21fed625a24d7ff707b5dab822a8ce5f9c2a53e4", "old_mode": 33188, "old_path": "ssl/internal.h", "new_id": "a4e2689967aa35305be61f5b54c4524969cdc562", "new_mode": 33188, "new_path": "ssl/internal.h" }, { "type": "modify", "old_id": "242ac267cb0b1f931b88b150c8f5b3f74a8300bf", "old_mode": 33188, "old_path": "ssl/s3_clnt.c", "new_id": "1c9f105422ac5905da25aafe8762567d574b41de", "new_mode": 33188, "new_path": "ssl/s3_clnt.c" }, { "type": "modify", "old_id": "637e6edae3a7ffd017f78774476df70b8ae30d72", "old_mode": 33188, "old_path": "ssl/s3_srvr.c", "new_id": "2c915e6b8ac9e7267cf9f30e374d417548c3f509", "new_mode": 33188, "new_path": "ssl/s3_srvr.c" }, { "type": "modify", "old_id": "6c4a847c0fd173b5603429c5bb5b2b08c2b8c2a4", "old_mode": 33188, "old_path": "ssl/ssl_lib.c", "new_id": "59a3a5021566d65f710296eeea64f3a9aa10f960", "new_mode": 33188, "new_path": "ssl/ssl_lib.c" }, { "type": "modify", "old_id": "4c2e4640bdafb6f2b759423460ea147341996bfe", "old_mode": 33188, "old_path": "ssl/ssl_session.c", "new_id": "6b17eedc6f902da3fde31d22854102592c4f0fb3", "new_mode": 33188, "new_path": "ssl/ssl_session.c" } ] }