| commit | db1a8456167249f95b854a1cd24c6b553d0f1567 | [log] [tgz] |
|---|---|---|
| author | Lily Chen <chlily@google.com> | Wed Oct 15 17:20:50 2025 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Oct 15 14:35:13 2025 -0700 |
| tree | ed599e17c3077e534a616ddd01ed40e3fcc5aaa9 | |
| parent | 338f44af3c92ef665bf740a8127a2d69c872b52a [diff] |
Add a PRESUBMIT.py script to check pregenerated files This adds a PRESUBMIT.py script that calls the existing go script to check pregenerated files. The goal is to catch errors due to missing/out-of-date pregenerated files earlier, upon commit or upload. This works with the presubmit API provided by depot_tools, and will only help you if you use depot_tools to manage local boringssl changes via `git cl upload`. (We already run the pregenerate script on CQ via the boringssl.py recipe. If we had a dedicated builder to run PRESUBMIT.py files on boringssl CQ via the presubmit recipe (which we don't yet), this script would also help catch the errors on dry run even earlier, even for folks not using depot_tools.) Output looks something like this: Running presubmit commit checks on branch my-branch-name ... ** Presubmit ERRORS: 1 ** Found out-of-date generated files. Run `go run ./util/pregenerate` to update them. Error in file "gen/crypto/chacha-armv4-linux.S": missing file Error in file "gen/crypto/aes128gcmsiv-x86_64-linux.S": file out of date Error: some files had errors exit status 1 Presubmit checks took 1.7s to calculate. There were presubmit errors. Was the presubmit check useful? If not, run "git cl presubmit -v" to figure out which PRESUBMIT.py was run, then run "git blame" on the file to figure out who to ask for help. Change-Id: Iad268831ad7353eb15c796906b3f73c12ab8cf80 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/82867 Auto-Submit: Lily Chen <chlily@google.com> Commit-Queue: Lily Chen <chlily@google.com> Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: