| commit | b173d9191d080c475f803965bd7639914a6d1dc3 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Apr 19 14:03:59 2021 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Apr 20 19:06:51 2021 +0000 |
| tree | 0727899ec95e7c0ec8aa135da14155c615fbf2e9 | |
| parent | 575d1128581c6751f93b0649253ba9d2d981d3e5 [diff] |
Remove support for malformed X509_ATTRIBUTEs. The X509_ATTRIBUTE structure includes a hack to tolerate malformed attributes that encode the value directly instead of a set of values. This form is never created by OpenSSL and shouldn't be needed any more. (Imported from upstream's e20b57270dece66ce2c68aeb5d14dd6d9f3c5d68.) This also changes X509_ATTRIBUTE_set1_data slightly. Previously, set1_data would override whatever was previously in the X509_ATTRIBUTE, but leak memory. Now set1_data appends to the set. (PKCS#10 attributes use SET OF ANY as value.) It's unclear to me if this was intentional on upstream's part. (The attrtype == 0 case only makes sense in the old behavior.) Since there is no other way to create a two-element SET and upstream has long since released this behavior, I left it matching upstream. Update-Note: Given OpenSSL hasn't accepted these for five years, it's unlikely anything depends on it. If something breaks, we can revert this and revisit. No one calls X509_ATTRIBUTE_set1_data on a non-empty X509_ATTRIBUTE, so the behavior change there should be safe. Change-Id: Ic03c793b7d42784072ec0d9a7b6424aecc738632 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/46947 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: