)]}'
{
  "commit": "d83dcf58c0e28f1837aaeb55ddc2c54c9a1a20ac",
  "tree": "8168f245c6fce3205b780bd6cf54ff7d031962fe",
  "parents": [
    "aec1b62b07a4465c3b6747a09ad69c614bc5766b"
  ],
  "author": {
    "name": "Adam Langley",
    "email": "alangley@gmail.com",
    "time": "Wed Nov 04 11:02:37 2020 -0800"
  },
  "committer": {
    "name": "Adam Langley",
    "email": "agl@google.com",
    "time": "Wed Nov 04 20:15:50 2020 +0000"
  },
  "message": "runner: explicitly signal error from handshaker.\n\nWhen the handshaker fails to parse a config it currently exits. This\ncauses the two pipes to signal EOF to the shim, but the control channel\nis a datagram socket in order to be atomic, thus doesn\u0027t signal an\nerror.\n\nIn the shim, EOF on the wfd pipe causes a short loop and thus a hang\nforever. Catching the EOF and returning an error doesn\u0027t work because\nsome tests will close the pipe but still return information over the\ncontrol channel. We can start a timeout once wfd is closed, but that\nseems like it might be flakey.\n\nThus this change makes the handshaker send an explicit error over the\ncontrol channel. It doesn\u0027t catch crashes, but it will catch config\nerrors, which are much more common in cross-version tests.\n\nChange-Id: I4b1afed17694c57e4713d1b0fa4e9ecb12f09ec5\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43865\nReviewed-by: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a6bf6432f40c7d5096168f443cace3d3dc1cf12a",
      "old_mode": 33188,
      "old_path": "ssl/test/handshaker.cc",
      "new_id": "72d6b2fdecb9db39f92ca6417cdab261af303627",
      "new_mode": 33188,
      "new_path": "ssl/test/handshaker.cc"
    }
  ]
}