)]}' { "commit": "d80f17d5c94b21c4fb2e82ee527bfe001b3553f2", "tree": "c37dcefa7f2c7cf03da033752a497934764636aa", "parents": [ "a94c267787df4ac0517456231ebc7be40442895f" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Wed Dec 29 15:34:37 2021 -0500" }, "committer": { "name": "Adam Langley", "email": "agl@google.com", "time": "Fri Jan 07 18:41:53 2022 +0000" }, "message": "Simplify __ARM_ARCH__ definition.\n\nOpenSSL\u0027s assembly files have a few places where we condition code on\n__ARM_ARCH__, the minimum target ARM revision. It currently only\ncontrols some pre-ARMv7 code. This symbol has, from what I can tell, the\nsame semantics as __ARM_ARCH, defined in Arm C Language Extensions, and\nadded in GCC 4.8 and Clang 3.2:\nhttps://gcc.gnu.org/git/?p\u003dgcc.git;a\u003dcommitdiff;h\u003d9e94a7fc5ab770928b9e6a2b74e292d35b4c94da;hp\u003d25bab91e017eb1d6d93117f3da96fa9b43703190\nhttps://github.com/llvm/llvm-project/commit/e98c4dbd1ef783b04f0d8276847076fb79a804e8\n\nThose are over nine years old, so drop all the fallback code. Also fix\narm_arch.h to be includable on non-ARM platforms. Some tools expect all\npublic headers to be cleanly includable and arm_arch.h being \"public\"\nwas getting in the way (see cl/416881417).\n\nInterestingly, arm_arch.h previously only computed __ARM_ARCH__ for\n__GNUC__ and Clang doesn\u0027t define __GNUC__ on Windows. That means we\nactually weren\u0027t defining __ARM_ARCH__ for Windows. But none of the\naarch64 assembly has __ARM_ARCH__-gated code, so it works out. If it\never does, that CL smooths that over. I\u0027ve gated the\n__ARM_(MAX_)_ARCH__ bits on __ASSEMBLER__ to avoid breaking no-asm\nWindows/aarch64 builds on MSVC. There aren\u0027t any uses in C.\n\nUpdate-Note: ARM assembly now requires the compiler define __ARM_ARCH.\nThis is not expected to break Clang or GCC from the last 8 or 9 years.\n\nChange-Id: Id45e95406edeecf8dda11dce9e82418516e9de1f\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/50849\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "3a34829e793ee648087553dbe7155ccee4ebb6fb", "old_mode": 33188, "old_path": "include/openssl/arm_arch.h", "new_id": "7215f62eb252c7fe797baf7c233042d2ba6a5faa", "new_mode": 33188, "new_path": "include/openssl/arm_arch.h" } ] }