| commit | 50bc2ea0e8f60fec17dad62ef6e54a8aed284511 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue Mar 14 18:28:20 2023 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 14 22:48:20 2023 +0000 |
| tree | aeedd43a3e332b6574578400a2214e73543af935 | |
| parent | 39da68f22fb420d069c1e0b2796e53c728839437 [diff] |
Tidy up HMAC_Init_ex slightly Guarding the OPENSSL_memset was unnecessary since OPENSSL_memset with zero length works fine. Also OPENSSL_memset, to workaround a C bug, internally does the same check anyway. (But also this wasn't a context where the C bug applied.) Also don't bother calling EVP_MD_block_size a second time when we already saved it into block_size. Finally, don't bother filling key_block up to the whole EVP_MAX_MD_BLOCK_SIZE size. I could believe the fixed size is easier for the compiler to optimize, but the XORs in setting up an HMAC cannot possibly be performance-sensitive, and using the actual length is clearer. Also add an assert that the hash's output size fits in the block size. We're implicitly relying on this when hashing the key down. Change-Id: I6ce37d41ea5bdbc8890bde7910e1b5651bc35709 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/58027 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com> Auto-Submit: David Benjamin <davidben@google.com> Commit-Queue: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: