runner: Bundle wire version, protocol version, and isDTLS together

We currently a mess of different notions of "version":

- The "wire version", the actual 16-bit code point on the wire. These
  were once numerically comparable, but then DTLS bit-flipped the
  versions, and then TLS 1.3 draft versions made them arbitrary.

- The "protocol version" which normalizes all this down into just one of
  TLS 1.0, TLS 1.1, TLS 1.2, TLS 1.3, which is comparable.

The way we stuck DTLS and later TLS 1.3 draft versions (since removed)
into runner, we ended up storing a pair of version and wire version and
having to keep track of which was being passed in at any point. And then
since the PRF code also cared about TLS vs DTLS (thanks to DTLS 1.3
changing the labels), we also passed an isDTLS in everywhere.

Bundle them into one type, which stores the wire version (captures all
information) but can convert to the protocol version. Since this type
should not be constructible with invalid values, the protocol version
getter can be infallible.

Since DTLS 1.3 has opted to continue the bitflipped scheme, it seems
we've settled on giving TLS and DTLS disjoint versions. That then means
the isDTLS bit is mostly captured by the version bit and can be removed
from all the PRF machinery. I say mostly because the initial
undetermined version is currently just represented with zero everywhere,
so the connection structures still need isDTLS booleans. But prf.go can
be satisfied with just a version struct and we trim away a bunch of
parameters.

This has the side effect of fixing the handshaker_server.go session
version comparison to compare the full wire version, and not just the
protocol version, avoiding e.g. DTLS and TLS cross-resume.

Change-Id: I1f93f7daf2da9ba303b16a857a0347b00fe994e7
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/89472
Reviewed-by: Lily Chen <chlily@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
13 files changed
tree: 1768954d06b1068095a43914a6a04e8b0af05620
  1. .bcr/
  2. bench/
  3. cmake/
  4. crypto/
  5. decrepit/
  6. docs/
  7. fuzz/
  8. gen/
  9. include/
  10. infra/
  11. pki/
  12. rust/
  13. ssl/
  14. third_party/
  15. tool/
  16. util/
  17. .bazelignore
  18. .bazelrc
  19. .bazelversion
  20. .clang-format
  21. .clang-format-ignore
  22. .gitignore
  23. API-CONVENTIONS.md
  24. AUTHORS
  25. BREAKING-CHANGES.md
  26. BUILD.bazel
  27. build.json
  28. BUILDING.md
  29. CMakeLists.txt
  30. codereview.settings
  31. CONTRIBUTING.md
  32. FUZZING.md
  33. go.mod
  34. go.sum
  35. INCORPORATING.md
  36. LICENSE
  37. MODULE.bazel
  38. MODULE.bazel.lock
  39. PORTING.md
  40. PRESUBMIT.py
  41. PrivacyInfo.xcprivacy
  42. README.md
  43. SANDBOXING.md
  44. SECURITY.md
  45. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: