| commit | ce572d6e9bde836016b200169abf81e71b2a55bf | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue Oct 22 12:35:44 2024 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 22 21:57:56 2024 +0000 |
| tree | 318e6c2804b30edd49a567a411c9f3f3ca700890 | |
| parent | 4f76523ffef78ba8650c3d4905c6ff90b82dc303 [diff] |
Standardize on Init vs InitForOverwrite for value vs default initialization C++ is fun and has two notions of "default" initialization, `new T` and `new T()`. These are default initialization and value initialization, respectively. They are identical except that POD types are uninit when default-initialized and zero when value-initialized. InplaceVector picked the safer option by default and called the other one FooMaybeUninit. Array is older and uses the less safe one (it's almost always the one we want; we usually allocate an array to immediately fill it). While MaybeUninit does capture what you do with it, it is slightly ambiguous, as seen in Array's internal implementation: uninitialized could also mean we haven't gotten around to initialize it at all. I.e. we need to use a function like std::uninitialized_value_construct_n instead of normal functions in <algorithm>. C++20 has std::make_unique and std::make_unique_for_overwrite to capture the two. This seems as fine a naming convention as any, so switch to it. Along the way, make the internal bssl::Array default to the safer one. This lets us remove a couple of memset(0)'s. Change-Id: I32cede231da051a854e6251e10b87f8e4dd06ee6 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/72268 Reviewed-by: Nick Harper <nharper@chromium.org> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: