commit ca0b603153e142a0a3bfbb9370adc9ba77d7113e
author David Benjamin <davidben@google.com> Wed Nov 16 07:34:53 2016 +0900
committer Adam Langley <agl@google.com> Wed Nov 16 19:19:38 2016 +0000
tree 724a690d5e50909f7b8562faa39427a374d91fb5
parent dc16f3868522719a26b5fa366769fb66f026bc49

Remove unnecessary BN_is_negative check in p256-x86_64_test.

A BN_ULONG[P256_LIMBS] can't represent a negative number and
bn_set_words won't produce one. We only need to compare against P.

Change-Id: I7bd1c9e8c162751637459f23f3cfc56884d85864
Reviewed-on: https://boringssl-review.googlesource.com/12304
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>

crypto/ec/p256-x86_64_test.cc

diff --git a/crypto/ec/p256-x86_64_test.cc b/crypto/ec/p256-x86_64_test.cc
index 07a8237..531edcf 100644
--- a/crypto/ec/p256-x86_64_test.cc
+++ b/crypto/ec/p256-x86_64_test.cc
@@ -154,10 +154,7 @@
   }
 
   // Coordinates must be fully-reduced.
-  if (BN_is_negative(x.get()) ||
-      BN_is_negative(y.get()) ||
-      BN_is_negative(z.get()) ||
-      BN_cmp(x.get(), p.get()) >= 0 ||
+  if (BN_cmp(x.get(), p.get()) >= 0 ||
       BN_cmp(y.get(), p.get()) >= 0 ||
       BN_cmp(z.get(), p.get()) >= 0) {
     return false;