Rename DTLS 1.3 TODOs.
Prior to the buganizer migration, the DTLS 1.3 tracking bug was
crbug.com/boringssl/715. To make it easier to find all TODOs for the
DTLS 1.3 work, this changes them to point to the same bug under the new
number.
Change-Id: I585c551947ded2b82e3e1faaf133a518961686ea
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/72407
Reviewed-by: David Benjamin <davidben@google.com>
Auto-Submit: Nick Harper <nharper@chromium.org>
Commit-Queue: David Benjamin <davidben@google.com>
diff --git a/ssl/dtls_method.cc b/ssl/dtls_method.cc
index 4b87221..27993da 100644
--- a/ssl/dtls_method.cc
+++ b/ssl/dtls_method.cc
@@ -89,9 +89,9 @@
DTLSReadEpoch new_epoch;
if (ssl_protocol_version(ssl) > TLS1_2_VERSION) {
- // TODO(crbug.com/boringssl/715): Handle the additional epochs used for key
+ // TODO(crbug.com/42290594): Handle the additional epochs used for key
// update.
- // TODO(crbug.com/boringssl/715): If we want to gracefully handle packet
+ // TODO(crbug.com/42290594): If we want to gracefully handle packet
// reordering around KeyUpdate (i.e. accept records from both epochs), we'll
// need a separate bitmap for each epoch.
new_epoch.epoch = level;
@@ -117,7 +117,7 @@
Span<const uint8_t> traffic_secret) {
DTLSWriteEpoch new_epoch;
if (ssl_protocol_version(ssl) > TLS1_2_VERSION) {
- // TODO(crbug.com/boringssl/715): See above.
+ // TODO(crbug.com/42290594): See above.
new_epoch.epoch = level;
new_epoch.rn_encrypter =
RecordNumberEncrypter::Create(aead_ctx->cipher(), traffic_secret);
diff --git a/ssl/ssl_test.cc b/ssl/ssl_test.cc
index 098c32a..dd295cc 100644
--- a/ssl/ssl_test.cc
+++ b/ssl/ssl_test.cc
@@ -3494,7 +3494,7 @@
TEST_P(SSLVersionTest, SessionIDContext) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -3635,7 +3635,7 @@
TEST_P(SSLVersionTest, SessionTimeout) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -3776,7 +3776,7 @@
TEST_P(SSLVersionTest, DefaultTicketKeyRotation) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -4484,7 +4484,7 @@
CreateClientSession(client_ctx_.get(), server_ctx_.get(), config);
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -4501,7 +4501,7 @@
// Test that session cache mode bits are honored in the client session callback.
TEST_P(SSLVersionTest, ClientSessionCacheMode) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -5572,7 +5572,7 @@
TEST_P(SSLVersionTest, SessionVersion) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -6229,7 +6229,7 @@
// Test that ticket-based sessions on the client get fake session IDs.
TEST_P(SSLVersionTest, FakeIDsForTickets) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -6365,7 +6365,7 @@
TEST_P(SSLVersionTest, SessionTicketThreads) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -8042,7 +8042,7 @@
TEST_P(SSLVersionTest, SameKeyResume) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -8084,7 +8084,7 @@
TEST_P(SSLVersionTest, DifferentKeyNoResume) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -8127,7 +8127,7 @@
TEST_P(SSLVersionTest, UnrelatedServerNoResume) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
@@ -8169,7 +8169,7 @@
TEST_P(SSLVersionTest, TicketSessionIDsMatch) {
if (version() == DTLS1_3_EXPERIMENTAL_VERSION) {
- // TODO(crbug.com/boringssl/715): Enable the rest of this test for DTLS 1.3
+ // TODO(crbug.com/42290594): Enable the rest of this test for DTLS 1.3
// once it supports NewSessionTickets.
return;
}
diff --git a/ssl/test/runner/runner.go b/ssl/test/runner/runner.go
index c0d4276..8a4dd55 100644
--- a/ssl/test/runner/runner.go
+++ b/ssl/test/runner/runner.go
@@ -3231,7 +3231,7 @@
},
resumeSession: true,
},
- // TODO(crbug.com/boringssl/715): This test and the next shouldn't be
+ // TODO(crbug.com/42290594): This test and the next shouldn't be
// restricted to a max version of TLS 1.2, but they're broken in DTLS 1.3.
{
protocol: dtls,
@@ -5054,7 +5054,7 @@
flags: []string{"-expect-hrr"},
})
- // TODO(crbug.com/boringssl/715): The -NoResume tests here are copies
+ // TODO(crbug.com/42290594): The -NoResume tests here are copies
// of the above tests, but without resumeSession set. These exist to
// test HRR in DTLS 1.3, because tests DTLS 1.3 tests with resumption
// enabled are skipped due to lack of support for resumption. Once we
@@ -5091,7 +5091,7 @@
// These tests are disabled for QUIC as well because they test features
// that do not apply to QUIC's use of TLS 1.3.
//
- // TODO(crbug.com/boringssl/715): Enable these tests for DTLS once we
+ // TODO(crbug.com/42290594): Enable these tests for DTLS once we
// support early data in DTLS 1.3.
if config.protocol != dtls && config.protocol != quic {
tests = append(tests, testCase{
