)]}'
{
  "commit": "c1af314f524ef4b5989f27d3ac2e0ed993408856",
  "tree": "212ed7880e08d21131bf058ddc633c2d6f6913cb",
  "parents": [
    "fda22fa7dbe9b841a2605ca78fbd32f2e3cb1a91"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Mon Apr 07 12:50:26 2025 -0400"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Apr 14 13:42:25 2025 -0700"
  },
  "message": "Add EVP_marshal_digest_algorithm_no_params\n\nSee https://boringssl-review.googlesource.com/c/boringssl/+/67088 for a\ndiscussion of the long and sordid history here. It seems the default is\nactually without NULL, but a bunch of use cases (primarily ones we care\nabout) require you to include the NULL due to historical mistakes.\n\nWe care about encoding digest AlgIds in:\n\n- RSASSA-PKCS1-v1_5 DigestInfo: NULL should be included, though we\n  don\u0027t use that function here.\n\n- RSASSA-PSS and RSAES-OAEP AlgIds: NULL should be included. We don\u0027t\n  use that function here, but we may in the future.\n\n- PKCS#12: This is ambiguous, but I think the best behavior for now is\n  to continue sending NULL. See comment added to that file.\n\n- OCSP: I think this actually should omit the NULL, but we, OpenSSL, and\n  Go all include it, so I\u0027ve included it for now.\n\n- PKCS#7 and (if we implement it) CMS: This should omit the NULL. We\n  currently don\u0027t use this function in our PKCS#7 implementation.\n\nAlthough the default probably should be to omit it, we seem to want to\ninclude it in almost all our current callers, I\u0027ve added a no_params\nvariant for the new behavior for now. In the future we can reevaluate\nthis and, if desired:\n\n- Add a with_null API\n- Make the unsuffixed one into the no_params one\n  (backwards-incompatible)\n- Retire the no_params one\n\nFixed: 42290589\nChange-Id: Icc62f9af8cddfbdb5317b3a0b0fb2bf46ff74408\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/78449\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "f68ede9156ee57526f4578953c350798a1299f00",
      "old_mode": 33188,
      "old_path": "crypto/digest/digest_extra.cc",
      "new_id": "4cbfa1f53bb669c24c7f055f4fee7f144f72115a",
      "new_mode": 33188,
      "new_path": "crypto/digest/digest_extra.cc"
    },
    {
      "type": "modify",
      "old_id": "8237fb86b8391c4a31ac838e2ca1cb575fa6b37e",
      "old_mode": 33188,
      "old_path": "crypto/digest/digest_test.cc",
      "new_id": "8cdc48df09b6ae679f5033e41bee6b99c381a5f7",
      "new_mode": 33188,
      "new_path": "crypto/digest/digest_test.cc"
    },
    {
      "type": "modify",
      "old_id": "aabc9a24b6d41a42cc2ad8b466fe441b09bffb18",
      "old_mode": 33188,
      "old_path": "crypto/pkcs7/pkcs7_x509.cc",
      "new_id": "5a767523f52b1d4119cd380d971f5eb60c3aa028",
      "new_mode": 33188,
      "new_path": "crypto/pkcs7/pkcs7_x509.cc"
    },
    {
      "type": "modify",
      "old_id": "60bcfd4a73a270098c8ed24d1b012ae9d0285cf5",
      "old_mode": 33188,
      "old_path": "crypto/pkcs8/pkcs8_x509.cc",
      "new_id": "ede84f7d068cfc43c74979a14fd82bdc8ab6b30f",
      "new_mode": 33188,
      "new_path": "crypto/pkcs8/pkcs8_x509.cc"
    },
    {
      "type": "modify",
      "old_id": "9c127471e0b0e41315f880f9a77e7e3c7431dbbc",
      "old_mode": 33188,
      "old_path": "include/openssl/digest.h",
      "new_id": "6abab7693ef2cf418e64d4bf5d53e7e0821cb731",
      "new_mode": 33188,
      "new_path": "include/openssl/digest.h"
    },
    {
      "type": "modify",
      "old_id": "7984050ab38ccf8f7cad710a7213bb256b0052e9",
      "old_mode": 33188,
      "old_path": "pki/ocsp.cc",
      "new_id": "e36fb88d4ddc1596b84d7949001a5e9665bd61b9",
      "new_mode": 33188,
      "new_path": "pki/ocsp.cc"
    }
  ]
}