| commit | 750fea158acd38bb339203fdab216079d997a921 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Wed Dec 05 13:12:48 2018 -0600 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Wed Dec 05 22:05:28 2018 +0000 |
| tree | c1e4c37ce42204aedda476bef04a53fb5adfbe35 | |
| parent | ff433815b51c34496bb6bea13e73e29e5c278238 [diff] |
Fix d2i_*_bio on partial reads. If BIO_read returns partial reads, d2i_*_bio currently fails. This is a partial (hah) regression from 419144adce049b5341bd94d355c52d099eac56e3. The old a_d2i_fp.c code did *not* tolerate partial reads in the ASN.1 header, but it *did* tolerate them in the ASN.1 body. Since partial reads are more likely to land in the body than the header, I think we can say d2i_*_bio was "supposed to" tolerate this but had a bug in the first few bytes. Fix it for both cases. Add a regression test for this and the partial write case (which works fine). See also https://github.com/google/conscrypt/pull/587. Change-Id: I886f6388f0b80621960e196cf2a56f5c02a14a04 Reviewed-on: https://boringssl-review.googlesource.com/c/33484 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: