Remove p224-64.cc.inc Instead, use the generic implementation for P-224. This is a *substantial* performance hit, but P-224 is no longer as important as it once was, and this file breaks some assumptions we'd otherwise be able to make in the EC implementation. OPENSSL_SMALL builds are not affected. This file was already not used in Chrome and Android. Benchmark Time CPU Time Old Time New CPU Old CPU New --------------------------------------------------------------------------------------------------------------------------------- BM_SpeedECDH/p224/threads:1 +3.2201 +3.2739 43679 184330 43123 184303 BM_SpeedECDSASign/p224/threads:1 +4.1784 +4.1797 19602 101506 19590 101468 BM_SpeedECDSAVerify/p224/threads:1 +1.1512 +1.1515 44381 95474 44373 95466 OVERALL_GEOMEAN +2.6091 +2.6248 0 0 0 0 Bug: 505908440 Change-Id: I809dc76b8a233f259f7cf834db022f3bb0a220f3 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/93867 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com> Auto-Submit: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: