)]}'
{
  "commit": "be84aeed7d21f5e5be37dee3c827175acebb6dda",
  "tree": "3473dc5f498454f2b7f5d3377aa2f1680247d970",
  "parents": [
    "8e7025e3dff220014e559d3ebbb47aa2516d0e1b"
  ],
  "author": {
    "name": "Adam Langley",
    "email": "agl@google.com",
    "time": "Tue Sep 05 20:53:37 2023 +0000"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Sep 06 16:43:18 2023 +0000"
  },
  "message": "acvptool: create fresh variables in loops.\n\nReferencing a variable in a closure captures it by _address_. So\nreferencing a loop variable can go horribly wrong:\nhttps://go.dev/play/p/f2ivPAIN_bG\n\nThis is accepted as essentially a bug by Go and will be fixed in a\nfuture release (https://github.com/golang/go/wiki/LoopvarExperiment).\nBut, for now at least, work around it.\n\nOur tests trim the ACVP inputs to only have a single test case per group\nin many cases, which hides most of this issue from tests. When we run\nrun full ACVP sets, our modulewrapper is seemingly fast enough not to\nnotice there either. But I\u0027ve updated one of the tests here by\nduplicating a test case enough that it catches this a meaningful amount\nof the time.\n\nChange-Id: I8216c00f67636ab7dad927eae4b49ae45ae3cf31\nBug: 646\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/62965\nReviewed-by: David Benjamin \u003cdavidben@google.com\u003e\nAuto-Submit: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ba0eee9666333174defb9fc61c3064c501c6d4c7",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/aead.go",
      "new_id": "c38b170736f97341adbef2b9c54b4ec0c51b9b5d",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/aead.go"
    },
    {
      "type": "modify",
      "old_id": "2f058027ec7fc04f6e68bb30a2bfe353b04f6ff6",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/block.go",
      "new_id": "bcc6613a2f8a307d446845829fb3634edacdd591",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/block.go"
    },
    {
      "type": "modify",
      "old_id": "b403f046140df4aac08f1c6667beffc6e6c3d9ef",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/drbg.go",
      "new_id": "87584d63d7835b1aad9c4211e5593eb1b768454f",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/drbg.go"
    },
    {
      "type": "modify",
      "old_id": "16d3a833554d8792422acdc97562a592f5cb5330",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/ecdsa.go",
      "new_id": "69706bdda650494f6ea995b76811b1e386794b7b",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/ecdsa.go"
    },
    {
      "type": "modify",
      "old_id": "1f34d1a9063c60bf85f69cf71d828ad1a06e069c",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/hash.go",
      "new_id": "aeac6d669d7642f203803886afaa988ae822f6ab",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/hash.go"
    },
    {
      "type": "modify",
      "old_id": "3a6ba04c6608738ce2f6f4b8fa6ce67a96a3c9ee",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/hkdf.go",
      "new_id": "c64e2b862dd05d65992f799584f51891c2111211",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/hkdf.go"
    },
    {
      "type": "modify",
      "old_id": "8fc76951c3d95b1b956a67ea6efdf40fa76baa59",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/hmac.go",
      "new_id": "6b8a3cfaecad7f689ea771c17d084d8cb6167b0c",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/hmac.go"
    },
    {
      "type": "modify",
      "old_id": "cbc99ed58dcf06d30f06c3c816ba2a9eadcf734f",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/kas.go",
      "new_id": "4c99f8aa38e43fbbd6db7348ab6771ecdf3b9b52",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/kas.go"
    },
    {
      "type": "modify",
      "old_id": "f262b820036366baa49356d66623bad5bca804d9",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/kasdh.go",
      "new_id": "212dd316578fae6d978cbb7b54e1fc4a3f8f2422",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/kasdh.go"
    },
    {
      "type": "modify",
      "old_id": "e27fcaa9ae37bbcd9f85cf629d36e9e0aa51c2aa",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/kdf.go",
      "new_id": "6e4145890afdaf590ec677e288c392240efd276d",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/kdf.go"
    },
    {
      "type": "modify",
      "old_id": "e43ab5d5314a34f65ad9fe84531e2a9e81298f17",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/keyedMac.go",
      "new_id": "c91bb4160721e43dc4604263bd12adf45ed1d666",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/keyedMac.go"
    },
    {
      "type": "modify",
      "old_id": "d975026e667c9fa02bd675e7ed2e52309c35ad51",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/rsa.go",
      "new_id": "923cdad0af450f40fc18d92fb2fda1596922bba0",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/rsa.go"
    },
    {
      "type": "modify",
      "old_id": "af2aae83586b0faf27b1b6a39b9e0cc85cd319b9",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/tls13.go",
      "new_id": "bd121422ed7a4f8edee87fdb41053ba7dcc03255",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/tls13.go"
    },
    {
      "type": "modify",
      "old_id": "3a0d7ceaf968365700ed27f56f52819870ca6046",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/tlskdf.go",
      "new_id": "251b53e6d37d2c6ee2b5d55853a00b33a8ffaa27",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/tlskdf.go"
    },
    {
      "type": "modify",
      "old_id": "e8134097381ba4b852618347463fbd495f8c3449",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/subprocess/xts.go",
      "new_id": "5a9e7402a98c79e7907afcebb45f0e7bfb9a812c",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/subprocess/xts.go"
    },
    {
      "type": "modify",
      "old_id": "d83b691619b9a4b97bd250490fa5642084680ae9",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/test/expected/TLS12.bz2",
      "new_id": "ff4ded067d9056f039bfd435c75b587bcee56433",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/test/expected/TLS12.bz2"
    },
    {
      "type": "modify",
      "old_id": "d1911ab9dde671ee395e38564cd8896c73fc7602",
      "old_mode": 33188,
      "old_path": "util/fipstools/acvp/acvptool/test/vectors/TLS12.bz2",
      "new_id": "00d9bbbed120c48708a07fbe7ec8b4f2a7fc9529",
      "new_mode": 33188,
      "new_path": "util/fipstools/acvp/acvptool/test/vectors/TLS12.bz2"
    }
  ]
}