)]}'
{
  "commit": "b15e56a69486d03996064500e2f06d6a5df5e6a0",
  "tree": "c03b25ece303ac12c267953ee340b134ee55294d",
  "parents": [
    "785bb12634b0d2fd39b1e34609bc50366443b67e"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Thu Dec 08 11:20:37 2022 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Dec 09 02:14:02 2022 +0000"
  },
  "message": "Add a tool to check whether a binary has an executable stack\n\nPlan is:\n\n1. This CL\n\n2. Update the CI/CQ recipe to be able to run this\n\n3. Update the CI/CQ config to enable this on ELF platforms\n\n4. Do not land, but patch out the .note.GNU-stack annotations and\n   -Wa,--noexecstack and confirm CI/CQ fails. Based on manual testing\n   and https://crbug.com/boringssl/292#c4, I anticipate we\u0027ll only have\n   coverage on x86 and x86_64 Linux. Currently, our only Arm Linux\n   builders are Android, which use the LLVM linker. The LLVM linker\n   doesn\u0027t have this design flaw, so it doesn\u0027t need .note.GNU-stack in\n   the first place. It also sounds like GNU ld will make this moot in a\n   future release.\n\n5. Remove -Wa,--noexecstack from crypto/CMakeLists.txt and confirm CI/CQ\n   still passes.\n\nOther than generally wanting to test things, the immediate motivation is\nhttps://boringssl-review.googlesource.com/c/boringssl/+/55626/1/crypto/perlasm/arm-xlate.pl#b246\n\nBug: 292\nChange-Id: Id1c049bfc2b4e8b7e2c8c32ea6456733a588dfe1\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/55645\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nCommit-Queue: Bob Beck \u003cbbe@google.com\u003e\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b718ea4acaa6d1c79b4aa7a817e6b9fcf5fa691b",
      "new_mode": 33188,
      "new_path": "util/check_stack.go"
    }
  ]
}