)]}'
{
  "commit": "b008298294418d67c1114c8b5f168a0368ecfc96",
  "tree": "0591117dd651a593c26e522956991e18ecdce327",
  "parents": [
    "db1bdbca1da02e1c033c8fe97b43f498ff567028"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Thu May 14 13:14:33 2026 -0400"
  },
  "committer": {
    "name": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu May 14 12:03:49 2026 -0700"
  },
  "message": "Switch STACK_OF(T) back to std::sort from std::stable_sort\n\nhttps://boringssl-review.googlesource.com/c/boringssl/+/91687 switched\nSTACK_OF(T)\u0027s sorting to a stable sort after a recently-added test\nexhibited some bugs depending on the sort order.\n\nWhat was actually going on was that the test made some incorrect\nassumptions on how X509_STORE behaved surrounding AKIDs, etc.\nhttps://boringssl-review.googlesource.com/c/boringssl/+/91787 fixed the\ntest to be less sensitive to this.\n\nstd::stable_sort is more likely to allocate and thus depend on the C++\nruntime. We do want to allow the C++ runtime in libcrypto, but there are\nsome hurdles to clear on Android first, so switch back to std::sort.\n(At a glance through output on godbolt, libc++\u0027s std::sort might\nactually be header-only!)\n\nThis does mean that, with the wrong sort order,\nX509StoreGet1IssuerMultipleMatches might test against the wrong\nbaseline. To prevent an unlikely false positive, remove the baselining\ncheck. With the baseline check removed, the test will never have a false\npositive, but we might have a false negative. I.e. we might fail to flag\na bug when it should. However, given the number of name collisions we\nput in there, and the number of different platforms and STLs we test\nagainst, this is unlikely. (Also that code should be rewritten to use a\nhash table anyway.)\n\nChange-Id: I1cca217ac713dbe7758fd4c102d901fdb6ebe177\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/95327\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Lily Chen \u003cchlily@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "44b3aa681fdc215d869a1d69b355dcd4c3dc2d6d",
      "old_mode": 33188,
      "old_path": "crypto/stack/stack.cc",
      "new_id": "89b4f954390f82873f7d5770fb6cbc044890887d",
      "new_mode": 33188,
      "new_path": "crypto/stack/stack.cc"
    },
    {
      "type": "modify",
      "old_id": "cc8927e09b16c39929b6f2a817872678d8e72fe9",
      "old_mode": 33188,
      "old_path": "crypto/stack/stack_test.cc",
      "new_id": "fbbfb79dc7b92443ea2887f8e92b03c35034386b",
      "new_mode": 33188,
      "new_path": "crypto/stack/stack_test.cc"
    },
    {
      "type": "modify",
      "old_id": "35faa485a37c844c5bac326b261a7ccc26d3bf8d",
      "old_mode": 33188,
      "old_path": "crypto/x509/x509_test.cc",
      "new_id": "d3ab671228662abd663a8642c9169bab551caac4",
      "new_mode": 33188,
      "new_path": "crypto/x509/x509_test.cc"
    },
    {
      "type": "modify",
      "old_id": "3bda50321911cc530d29483798c4c477597552e3",
      "old_mode": 33188,
      "old_path": "include/openssl/stack.h",
      "new_id": "c88f6b375e13aa6c6d60d5dedbf43fd0e879bf8a",
      "new_mode": 33188,
      "new_path": "include/openssl/stack.h"
    }
  ]
}