| commit | afa460c7b92c646a2c0d0537e14770a2b71cb762 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Mon Dec 05 19:43:49 2022 -0500 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 01 17:59:40 2023 +0000 |
| tree | 71f8e4c54865695671c0278b8ef41c7cc5e7dcd0 | |
| parent | 1df70cea5daa391e10f5df9057c60fd740b912ab [diff] |
Unexport and remove support for implicit tagging on ASN1_ITYPE_EXTERN. Currently, the only EXTERN type is X509_NAME. Implicitly tagging an X509_NAME didn't work anyway because of the cached encoding. Moreover, even if it did work, it'd be invalid. Name in RFC 5280 is actually a one-element CHOICE type, and CHOICE types can never be implicitly tagged. So just remove support. One thing of note: I'm thinking EXTERN can be used later to retain ASN1_ITEM compatibility, once X509 and friends no longer use the template machinery. That means we're not only assuming X509_NAME is never implicitly tagged, but also that external callers using <openssl/asn1t.h> won't implicitly tag a built-in type. This removes a case we need to handle in the rewritten tasn_enc.c. (In particular, crypto/asn1 and crypto/bytestring use a different tag representation and I'd like to minimum the number of conversions we need.) Update-Note: IMPLEMENT_EXTERN_ASN1 can no longer be used outside the library. I found no callers using this machinery, and we're better off gradually migrating every <openssl/asn1t.h> user to CBS/CBB anyway. Bug: 548 Change-Id: I0aab531077d25960dd3f16183656f318d78a0806 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/56186 Reviewed-by: Bob Beck <bbe@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: