tree 411a14db61451a6498ea98d23f4f2285a0687f4a
parent 22bb031c436c352498a05cd0881575908467a742
author Adam Langley <agl@chromium.org> 1406746517 -0700
committer Adam Langley <agl@google.com> 1406832562 +0000

Use asm directives to protect OPENSSL_cleanse.

Compilers have a bad habit of removing "superfluous" memset calls that
are trying to zero memory. For example, when memset()ing a buffer and
then free()ing it, the compiler might decide that the memset is
unobservable and thus can be removed.

Previously we tried to stop this by a) implementing memset in assembly
on x86 and b) putting the function in its own file for other platforms.

This change removes those tricks in favour of using asm directives to
scare the compiler away. As best as our compiler folks can tell, this is
sufficient and will continue to be so.

Change-Id: I40e0a62c3043038bafd8c63a91814a75a3c59269
Reviewed-on: https://boringssl-review.googlesource.com/1339
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>