commit ac4d5346ad20e29a4f4e6db05ce41780b4463d46
author David Benjamin <davidben@google.com> Fri Nov 17 01:42:04 2017 +0800
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Mon Nov 20 16:59:08 2017 +0000
tree 9a41a03afbdbda3916b79975d8d9c4e68eeec687
parent b8d677bfd0c9a3a8cce2fa026ce07fb218b0fb51

Add missing error path.

Error paths must always have OPENSSL_PUT_ERROR.

Change-Id: I0ed8c8288484a4ea69ec58317064ad3cd90ddd64
Reviewed-on: https://boringssl-review.googlesource.com/23104
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

ssl/t1_lib.cc

diff --git a/ssl/t1_lib.cc b/ssl/t1_lib.cc
index a7bfec4..8d03623 100644
--- a/ssl/t1_lib.cc
+++ b/ssl/t1_lib.cc
@@ -2147,6 +2147,7 @@
   if (!CBS_get_u16(contents, &group_id) ||
       !CBS_get_u16_length_prefixed(contents, &peer_key) ||
       CBS_len(contents) != 0) {
+    OPENSSL_PUT_ERROR(SSL, SSL_R_DECODE_ERROR);
     *out_alert = SSL_AD_DECODE_ERROR;
     return false;
   }