commit | aba057a4e09a80cf8de4f43a8caaee30cdb799be | [log] [tgz] |
---|---|---|
author | David Benjamin <davidben@google.com> | Mon Sep 11 15:21:43 2017 -0400 |
committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Tue Sep 12 15:56:59 2017 +0000 |
tree | 25e639355595482e59b8627f0a626182bb5d78f5 | |
parent | 1682126fd81ca12089323b936484e17285c36602 [diff] |
Work around a Java client bug when rotating certificates. The Java client implementation of the 3SHAKE mitigation incorrectly rejects initial handshakes when all of the following are true: 1. The ClientHello offered a session. 2. The session was successfully resumed previously. 3. The server declines the session. 4. The server sends a certificate with a different SAN list than in the previous session. (Note the 3SHAKE mitigation is to reject certificates changes on renegotiation, while Java's logic applies to initial handshakes as well.) The end result is long-lived Java clients break on some certificate rotations. Fingerprint Java clients and decline all offered sessions. This avoids (2) while still introducing new sessions to clear any existing problematic sessions. See also b/65323005. Change-Id: Ib2b84c69b5ecba285ffb8c4d03de5626838d794e Reviewed-on: https://boringssl-review.googlesource.com/20184 Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: