)]}'
{
  "commit": "ab4037e3d14b2b1e02c93f76d80a8dd0ce3193fc",
  "tree": "65611b5aa6da155d425fba15c51265c65ec69b71",
  "parents": [
    "0ff377a30c10e7ea34eb5efc5b5a8ebb90d8ba9a"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Sat Feb 03 23:22:06 2024 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Feb 22 22:41:50 2024 +0000"
  },
  "message": "Add some tests for X509_LOOKUP_hash_dir\n\nWriting these tests revealed that actually this has been broken on\nWindows this whole time!\n\nFirst, the APIs to configure a directory actually configure a\ncolon-separated list of directories. But file paths contain colons on\nWindows, so the actual separator on Windows is semicolon. But that got\nlost in the fork at some point. This CL fixes that.\n\nSecond, X509_FILETYPE_ASN1 is broken because of a text vs binary mode\nmixup. The following CL will fix this.\n\nSome of the behaviors tested here around CRLs are not quite reasonable.\nSee https://crbug.com/boringssl/690 for details. For now, I\u0027ve tried to\ncapture the existing behavior. As BY_DIR actually maintains some shared\nmutable state, I\u0027ve also added TSAn tests.\n\nAnother subtlety is that multiple CAs with the same name work, but the\nreason they work is pretty messy because OpenSSL\u0027s internal interfaces\nare incompatible with it. Instead, OpenSSL works around itself with the\nX509_STORE cache. These tests do not cover this case, but a subsequent\nCL will add tests for it.\n\nChange-Id: Ifd8f2faea164edb0eda771350cd9bf6dc94104e7\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/66008\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ede0d763fed0640459c72cd912a7bdbfbb9ee0fb",
      "old_mode": 33188,
      "old_path": "crypto/test/file_util.cc",
      "new_id": "f593e1d3f45db07e62b011c69711d74a977e2734",
      "new_mode": 33188,
      "new_path": "crypto/test/file_util.cc"
    },
    {
      "type": "modify",
      "old_id": "51752b4fa1eccbe0dd8e22830bb688db2bc289e7",
      "old_mode": 33188,
      "old_path": "crypto/test/file_util.h",
      "new_id": "0fd8d85e24e03c23546d9e33ae28a245aba0345a",
      "new_mode": 33188,
      "new_path": "crypto/test/file_util.h"
    },
    {
      "type": "modify",
      "old_id": "f5e4787224d9ac087045352dbe6c7d1838ac7dd5",
      "old_mode": 33188,
      "old_path": "crypto/x509/by_dir.c",
      "new_id": "d675f29bb5edaafe07c0eedc6df94f7db4081046",
      "new_mode": 33188,
      "new_path": "crypto/x509/by_dir.c"
    },
    {
      "type": "modify",
      "old_id": "6b06b7c00a0ba6b608e6d10c5ac98045334b6887",
      "old_mode": 33188,
      "old_path": "crypto/x509/x509_test.cc",
      "new_id": "61bc54d228a3031be6a01cc4964a30332ec34353",
      "new_mode": 33188,
      "new_path": "crypto/x509/x509_test.cc"
    },
    {
      "type": "modify",
      "old_id": "38e367ad6afdd88b61404d0648a324a553b64242",
      "old_mode": 33188,
      "old_path": "include/openssl/x509.h",
      "new_id": "b2eafccd1e3e01e8cee264ac57bce0d4d1728589",
      "new_mode": 33188,
      "new_path": "include/openssl/x509.h"
    }
  ]
}