)]}'
{
  "commit": "a9bdeed0cbf79003c6edcff7634f5f0cea183c9f",
  "tree": "53bf85b4a3ddd3bf3358389151b0b81ac9f48f78",
  "parents": [
    "d3f61eeacbf7fda857c1d8bbba56e3b5cb6cc2df"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Sun Jan 05 11:38:23 2025 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Jan 08 09:27:13 2025 -0800"
  },
  "message": "Add something to the error queue when Proc-Type version is wrong\n\nThe Proc-Type header starts with a version number. From RFC 1421,\nSection 4.6.1.1:\n\n\u003e  The \"Proc-Type:\" field has two subfields, separated by a comma.  The\n\u003e  first subfield is a decimal number which is used to distinguish among\n\u003e  incompatible encapsulated header field interpretations which may\n\u003e  arise as changes are made to this standard.  Messages processed\n\u003e  according to this RFC will carry the subfield value \"4\" to\n\u003e  distinguish them from messages processed in accordance with prior PEM\n\u003e  RFCs.\n\nRFC 1421 was an update of RFC 1113, which used X-Proc-Type: 3,ENCRYPTED,\nwhich we do not support. RFC 1040 defined X-Proc-Type: 2 and RFC 989\ndefined X-Proc-Type: 1,E. As far as I can tell, no other numbers for\nProc-Type have ever existed, and likely never will.\n\nIf we were to ever Proc-Type: 5, we currently return failure but forget\nto put something on the error queue. It\u0027s possible this was originally\ndone for extensibility, but it just breaks internal invariants. By\nreturning zero, the callers will treat this as an error anyway. We\u0027ll\njust confuse code that expects OpenSSL to return an error. Also\nOpenSSL\u0027s PEM APIs all treat failure to decrypt (e.g. due to unsupported\nfuture cipher) as an error, so we should treat an unsupported future PEM\nencryption scheme as an error too.\n\nChange-Id: Ia1f4f6776fea8d8a465a73105bf3ce24a587f26b\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/74809\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2a4b73af2d238e952b9de086fb2b1cb108c8ca3a",
      "old_mode": 33188,
      "old_path": "crypto/err/pem.errordata",
      "new_id": "0856f740455dc272bb3bee1e9ee81512ec5e6d7e",
      "new_mode": 33188,
      "new_path": "crypto/err/pem.errordata"
    },
    {
      "type": "modify",
      "old_id": "61ab5510e15ab310688b8226e7c14a0d237e3526",
      "old_mode": 33188,
      "old_path": "crypto/pem/pem_lib.cc",
      "new_id": "3a54348f4e015c61d02bf6658bd188127f5409c3",
      "new_mode": 33188,
      "new_path": "crypto/pem/pem_lib.cc"
    },
    {
      "type": "modify",
      "old_id": "7b309542a212acb6f081c5aa1eef11847e915fbc",
      "old_mode": 33188,
      "old_path": "crypto/pem/pem_test.cc",
      "new_id": "30fe10aa04c5655aad63d614a19c2877558f9c75",
      "new_mode": 33188,
      "new_path": "crypto/pem/pem_test.cc"
    },
    {
      "type": "modify",
      "old_id": "48bce027621f1de723c3bd19dd5fba20685c7ca3",
      "old_mode": 33188,
      "old_path": "gen/crypto/err_data.cc",
      "new_id": "6657eb5bdb042bbbcea261323c86fdc2275c0c25",
      "new_mode": 33188,
      "new_path": "gen/crypto/err_data.cc"
    },
    {
      "type": "modify",
      "old_id": "797e7f09775be523ffeebb80def6ee38b48354a0",
      "old_mode": 33188,
      "old_path": "include/openssl/pem.h",
      "new_id": "28bf3f286c16b90aa1d02e8806f435301ca785f6",
      "new_mode": 33188,
      "new_path": "include/openssl/pem.h"
    }
  ]
}