| commit | a934ee9e1fe4397e682f9f18b1f4f061d7400f9d | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Sat Mar 15 02:07:05 2025 +0700 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 16 11:04:33 2025 -0700 |
| tree | 23348a22eff003adae76d745f72221db3f121409 | |
| parent | 0b535498eae6b66da8b9534e7ca55a561248d90b [diff] |
Remove the need for scratch space when squaring BN_sqr only has scratch space because it needs to compute a temporary buffer with the a[i]^2 terms to add into the final result. But those terms can be computed and added in a single pass. This isn't expected to have any performance impact on assembly-enabled builds. All those builds have bn_mul_mont optimizations, which means the plain squaring operation is more-or-less unused. (This begs the question why we have assembly optimizations for it, when it's only used in conjunction with builds that barely use it, but ah well.) On NO_ASM builds, the plain square operation is used more, but this impacts linearly many terms out of an overall quadratic operation. I was unable to measure a consistent difference with or without this change. Really the benefit is that, by removing the dependency on scratch space, we can remove the dependency on BN_CTX and can unify our various Montgomery multiplication codepaths. Bug: 42290433 Change-Id: I1527bd212529bbd4a1abedec22bb1dc3d7e12cbb Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/79307 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com> Auto-Submit: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: