)]}' { "commit": "a7a75f208caea8a303615724d4cc5f4e8dfb9695", "tree": "23163d582cfff54661eee51ab20d3b1b645214ca", "parents": [ "f3bd757ee5e7ad409d2fdf7c3bb5fdfa5f0a307a" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Sat Oct 12 23:24:39 2019 -0400" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Tue Oct 15 20:29:17 2019 +0000" }, "message": "Do fewer trial divisions for larger RSA keygens.\n\nNow that Miller-Rabin can reject composites faster, we can do fewer\ntrial divisions. Halving the table seems to improve things for RSA-3072\nand RSA-4096. I left RSA-2048 alone since measurements with it halved\nwere a bit more of a wash.\n\n(Although now that I\u0027ve left it alone, it\u0027s gotten faster, so these\nnumbers are generally noisy.)\n\nBefore:\nDid 320 RSA 2048 key-gen operations in 30132984us (10.6 ops/sec)\n min: 27703us, median: 81774us, max: 375687us\nDid 84 RSA 3072 key-gen operations in 30166627us (2.8 ops/sec)\n min: 86961us, median: 322184us, max: 1170392us\nDid 30 RSA 4096 key-gen operations in 30644802us (1.0 ops/sec)\n min: 260916us, median: 772364us, max: 2743435us\n\nAfter:\nDid 345 RSA 2048 key-gen operations in 30103781us (11.5 ops/sec)\n min: 23359us, median: 75033us, max: 267159us\nDid 91 RSA 3072 key-gen operations in 30185495us (3.0 ops/sec)\n min: 72531us, median: 267385us, max: 1119039us\nDid 38 RSA 4096 key-gen operations in 30473203us (1.2 ops/sec)\n min: 228529us, median: 720027us, max: 2039681us\n\nChange-Id: I52d431347a70572034ced5b7778a2edac8f15173\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/38168\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "8c70e69583cd96c0522aad1eec95ce234805ec4f", "old_mode": 33188, "old_path": "crypto/fipsmodule/bn/prime.c", "new_id": "9df4f95c14918d6b1b5a04749d3c65623cabd40b", "new_mode": 33188, "new_path": "crypto/fipsmodule/bn/prime.c" } ] }