tree e85749fe66ef63a018962182c5540c3afcf3b265
parent 491af10360050f53833290d9ec89583b5b2dd007
author David Benjamin <davidben@google.com> 1635512730 -0400
committer Adam Langley <agl@google.com> 1635787254 +0000

Remove support for constructed strings in crypto/asn1.

Constructed strings are a BER mechanism where a string type can be
represented as a tree of constructed nodes and primitive leaves, that
then have to be concatenated by the parser. This is prohibited in DER
and a significant source of complexity in our parser.

Note this change does not affect our PKCS#7 and PKCS#12 parsers (where
BER is sadly necessary for interop) because those use CBS.

Update-Note: Invalid certificates (and the few external structures using
asn1t.h) with BER constructed strings will now be rejected.

Bug: 354
Change-Id: I5a8ee028ec89ed4f2d5c099a0588f2029b864580
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/50286
Reviewed-by: Adam Langley <agl@google.com>