)]}'
{
  "commit": "a6b6b804a05d7ece17efe700854ead9e0a0b2835",
  "tree": "b9393b289f114639536edd83d1d1768cbf2ac139",
  "parents": [
    "92de0b53a799a8724865fe816200c1421381d128"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue Dec 08 17:31:35 2020 -0500"
  },
  "committer": {
    "name": "CQ bot account: commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Tue Dec 08 23:14:15 2020 +0000"
  },
  "message": "Align armv8.pl references to OPENSSL_armcap_P.\n\nThis imports d741debb320bf54e8575d35603a44d4eb40fa1f9 from upstream.\nWe\u0027ve been managing the shared libraries already because our\narm-xlate.pl automatically adds .hidden to .extern lines, but nice to\nreduce the diff. (This does result in some duplicate .hidden lines in\nthe generated output, but we still want the arm-xlate.pl patch to\nautomatically hide .globl.)\n\nRemoving .comm lines does change the generated output, but having each\nasm file define its own copy of OPENSSL_armcap_P as a common symbol\nalways seemed odd. I recall some weird issue where the armv4.pl files\nsubtly rely on it for iOS\u0027s strange .indirect_symbol machinery. (Not\nactually because iOS wants a common symbol but because arm-xlate.pl\nrepurposes .comm to trigger .indirect_symbol.) Fortunately, aarch64 is\nmuch better about PC-relative addressing, so it should be a no-op.\n\nThe .comm lines have also previously caused weird issues\n(https://boringssl-review.googlesource.com/c/boringssl/+/32324), so\nit\u0027s generally nice to get rid of them.\n\nUpdate-Note: If aarch64 builds get some weird error about relocations,\nit\u0027s this CL\u0027s fault.\n\nChange-Id: I763ffa6cda750d99694ded8a5b68d7b27b09cfc9\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/44464\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "05958c8323cb6e842edb0fdcfadd0872c5bd432e",
      "old_mode": 33261,
      "old_path": "crypto/chacha/asm/chacha-armv8.pl",
      "new_id": "9c1c2d4f6d0c1716eb2388b9c1ed3aa30b346887",
      "new_mode": 33261,
      "new_path": "crypto/chacha/asm/chacha-armv8.pl"
    },
    {
      "type": "modify",
      "old_id": "dfde8c9adc32b9c61356a100320c3614c677d220",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/sha/asm/sha1-armv8.pl",
      "new_id": "0a3acaccc051fda839d2384c37882732fad90962",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/sha/asm/sha1-armv8.pl"
    },
    {
      "type": "modify",
      "old_id": "aff41cee6251a985a9dbaa0785325be7a0a850a0",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/sha/asm/sha512-armv8.pl",
      "new_id": "8b671e2eb28debe857468b4b21f30c7b918e07c2",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/sha/asm/sha512-armv8.pl"
    },
    {
      "type": "modify",
      "old_id": "7b9b45441a1f8fabf579204412817bc3690a3310",
      "old_mode": 33188,
      "old_path": "util/diff_asm.go",
      "new_id": "710a42cb692eab6ee4cd1e16cf4f11a161de178d",
      "new_mode": 33188,
      "new_path": "util/diff_asm.go"
    }
  ]
}