commit a3add9e5174ac3917b02e302c610ee51d923d053
author Bob Beck <bbe@google.com> Fri Aug 25 16:40:58 2023 +0000
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 25 16:57:54 2023 +0000
tree dc386062d4397d5d97f87ca6e9c867728e538a67
parent 50e30518df5022a86309d20d8c7471ed4c2f5a7e

Ensure OPENSSL_EXPORT is only on the class not methods.

Windows gets mad otherwise

bug: chromium:1322914

Change-Id: I3f0409ff9b397cb6a888f8c81642737721912cb0
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/62706
Auto-Submit: Bob Beck <bbe@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: David Benjamin <davidben@google.com>

pki/fillins/ip_address.h

diff --git a/pki/fillins/ip_address.h b/pki/fillins/ip_address.h
index cc8030c..1a92adc 100644
--- a/pki/fillins/ip_address.h
+++ b/pki/fillins/ip_address.h
@@ -22,25 +22,25 @@
  public:
   enum : size_t { kIPv4AddressSize = 4, kIPv6AddressSize = 16 };
 
-  OPENSSL_EXPORT IPAddress();
-  OPENSSL_EXPORT IPAddress(const uint8_t *address, size_t address_len);
-  OPENSSL_EXPORT IPAddress(uint8_t b0, uint8_t b1, uint8_t b2, uint8_t b3);
-  OPENSSL_EXPORT IPAddress(uint8_t b0, uint8_t b1, uint8_t b2, uint8_t b3,
-                           uint8_t b4, uint8_t b5, uint8_t b6, uint8_t b7,
-                           uint8_t b8, uint8_t b9, uint8_t b10, uint8_t b11,
-                           uint8_t b12, uint8_t b13, uint8_t b14, uint8_t b15);
+  IPAddress();
+  IPAddress(const uint8_t *address, size_t address_len);
+  IPAddress(uint8_t b0, uint8_t b1, uint8_t b2, uint8_t b3);
+  IPAddress(uint8_t b0, uint8_t b1, uint8_t b2, uint8_t b3,
+            uint8_t b4, uint8_t b5, uint8_t b6, uint8_t b7,
+            uint8_t b8, uint8_t b9, uint8_t b10, uint8_t b11,
+            uint8_t b12, uint8_t b13, uint8_t b14, uint8_t b15);
 
   static IPAddress IPv4AllZeros();
 
-  OPENSSL_EXPORT bool IsIPv4() const;
-  OPENSSL_EXPORT bool IsIPv6() const;
-  OPENSSL_EXPORT bool IsValid() const;
+  bool IsIPv4() const;
+  bool IsIPv6() const;
+  bool IsValid() const;
 
-  OPENSSL_EXPORT const uint8_t *data() const;
-  OPENSSL_EXPORT size_t size() const;
-  OPENSSL_EXPORT const IPAddressBytes &bytes() const;
+  const uint8_t *data() const;
+  size_t size() const;
+  const IPAddressBytes &bytes() const;
 
-  OPENSSL_EXPORT bool operator==(const IPAddress &other) const {
+  bool operator==(const IPAddress &other) const {
     return addr_ == other.addr_;
   }
 

pki/fillins/openssl_util.h

diff --git a/pki/fillins/openssl_util.h b/pki/fillins/openssl_util.h
index 3ee173a..f193a51 100644
--- a/pki/fillins/openssl_util.h
+++ b/pki/fillins/openssl_util.h
@@ -17,8 +17,8 @@
 // the OpenSSL error stack on function exit.
 class OPENSSL_EXPORT OpenSSLErrStackTracer {
  public:
-  OPENSSL_EXPORT OpenSSLErrStackTracer();
-  OPENSSL_EXPORT ~OpenSSLErrStackTracer();
+  OpenSSLErrStackTracer();
+  ~OpenSSLErrStackTracer();
 };
 
 }  // namespace fillins

pki/fillins/path_service.h

diff --git a/pki/fillins/path_service.h b/pki/fillins/path_service.h
index aa79e53..9763d3b 100644
--- a/pki/fillins/path_service.h
+++ b/pki/fillins/path_service.h
@@ -15,13 +15,12 @@
 
 class OPENSSL_EXPORT FilePath {
  public:
-  OPENSSL_EXPORT FilePath();
-  OPENSSL_EXPORT FilePath(const std::string &path);
+  FilePath();
+  FilePath(const std::string &path);
 
-  OPENSSL_EXPORT const std::string &value() const;
+  const std::string &value() const;
 
-  OPENSSL_EXPORT FilePath
-  AppendASCII(const std::string &ascii_path_element) const;
+  FilePath AppendASCII(const std::string &ascii_path_element) const;
 
  private:
   std::string path_;