tree 1ae7e050660f7d252f049140e108c7d750b5788f
parent c5c85defb2f3bfb6a462a47da8e2e2c354dbf926
author Adam Langley <agl@google.com> 1447704272 -0800
committer Adam Langley <agl@google.com> 1447711186 +0000

Have |CBB_init| zero the |CBB| before any possible failures.

People expect to do:

CBB foo;

if (!CBB_init(&foo, 100) ||
    …
    …) {
  CBB_cleanup(&foo);
  return 0;
}

However, currently, if the allocation of |initial_capacity| fails in
|CBB_init| then |CBB_cleanup| will operate on uninitialised values. This
change makes the above pattern safe.

Change-Id: I3e002fda8f0a3ac18650b504e7e84a842d4165ca
Reviewed-on: https://boringssl-review.googlesource.com/6495
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>