| commit | 6ef1b6455821f0d1c6b61ba91ba0cadd374d4049 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Sun Dec 30 19:27:46 2018 +0000 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Wed Jan 02 23:33:31 2019 +0000 |
| tree | 8855feaed3ad3a38bb8b2e5e024b57ced25cb228 | |
| parent | 1c55e54eda2cb8d099c047cac43db3f3f0680aef [diff] |
Add a comment about ecp_nistz256_point_add_affine's limitations. ecp_nistz256_point_add_affine does not support the doubling case and, unlike ecp_nistz256_point_add which does a tail call, computes the wrong answer. Note TestPointAdd in the unit tests skips this case. This works fine because we only use ecp_nistz256_point_add_affine for the g_scalar term, which is fully computed before the p_scalar term. (Additionally it requires that the windowing pattern never hit the doubling case for single multiplication.) But this is not obvious from reading the multiplication functions, so leave a comment at the call site to point this out. Change-Id: I08882466d98030cdc882a5be9e702ee404e80cce Reviewed-on: https://boringssl-review.googlesource.com/c/33945 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: