| commit | a2938719a4cfb5935f8332d0ca868001d0fc9bab | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue Apr 10 18:35:16 2018 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Fri Apr 20 21:34:05 2018 +0000 |
| tree | 8fc23109b6576093b1688d596cfe6d6f8e85bb6b | |
| parent | 9af9b946d2b38c0310f409cc4a071c5f6978b0ae [diff] |
Improve the RSA key generation failure probability. The FIPS 186-4 algorithm we use includes a limit which hits a 2^-20 failure probability, assuming my math is right. We've observed roughly 2^-23. This is a little large at scale. (See b/77854769.) To avoid modifying the FIPS algorithm, retry the whole thing four times to bring the failure rate down to 2^-80. Along the way, now that I have the derivation on hand, adjust https://boringssl-review.googlesource.com/22584 to target the same failure probability. Along the way, fix an issue with RSA_generate_key where, if callers don't check for failure, there may be half a key in there. Change-Id: I0e1da98413ebd4ffa65fb74c67a58a0e0cd570ff Reviewed-on: https://boringssl-review.googlesource.com/27288 Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: