| commit | 69c26de93c82ad98daecaec6e0c8644cdf74b03f | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue Jan 16 12:59:53 2024 -0500 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 16 18:31:44 2024 +0000 |
| tree | c92a390bca8e245e5a9fe2a756660b133712f505 | |
| parent | d4393891414c64a46257bc3d74e794e9d7313f73 [diff] |
Disable the __SHA__ static check for now https://boringssl-review.googlesource.com/c/boringssl/+/64208 caused us to skip the runtime check for SHA extensions when SHA is statically available. This change was correct (though we don't get the size wins without also emulating -ffunction-sections in the asm file), but we've run into a few places where projects build with -march=goldmont, but need a build that does not require SHA extensions: - Some CrOS toolchain definitions are incorrect and build with -march=goldmont when targetting boards that are not Goldmont. b/320482539 tracks fixing this. - Sometimes projects build with -march=goldmont as a rough optimized baseline. However, Intel CPU capabilities are not strictly linear, so this does not quite work. Some combination of -mtune and -march=x86-64-v{1,2,3,4} would be a better strategy here. - QEMU versions before 8.2 do not support SHA extensions and disable it with a warning. Projects that target Goldmont and test on QEMU will break. The long-term fix is to update to 8.2. A principled short-term fix would be -march=goldmont -mno-sha, to reflect that the binary needs to run on both QEMU-8.1-Goldmont and actual-Goldmont. Other than the CrOS issue, the others have been resolved or at least worked around, so once the CrOS issue is fixed, and the changes made their way through the pipeline, we can try this again. Though with the QEMU issue, the longer we wait, the less likely we'll trip people running old QEMUs. Bug: b:320482539 Change-Id: Iab30a441fce313a1413a465f88d7d52cde179292 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65407 Reviewed-by: Adam Langley <agl@google.com> Auto-Submit: David Benjamin <davidben@google.com> Commit-Queue: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: