Base BIO_free's return value on only the input BIO In so far as this return value makes any sense (it doesn't), it should report the status of just the input BIO. See bug for discussion. Update-Note: BIO_free(bio) will now consistently return one if this was the last reference to bio. Previously, it would return zero if bio were freed, but bio->next_bio were still shared. Affected applications should be rare; BIO chains are rare, and applications should not be looking at BIO_free's return value anyway. Bug: 485657226 Change-Id: Ib82637fc9d16decf207d9d19c73aba1e168e0beb Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/89708 Commit-Queue: Xiangfei Ding <xfding@google.com> Reviewed-by: Xiangfei Ding <xfding@google.com> Auto-Submit: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: