Add a value barrier to EVP_sha256_final_with_secret_suffix too

In https://boringssl-review.googlesource.com/c/boringssl/+/85628, we
added a value barrier to is_last_block because Clang had started undoing
the constant-time for those few operations. This is part of the Lucky 13
mitigation the legacy TLS CBC_SHA ciphers.

Turned out the legacy TLS CBC_SHA256 ciphers had the same problem. But
because we didn't have EVP_AEAD-level tests for them, this went
unnoticed.

Thanks to Alex Gaynor for noticing that the two functions were
inconsistently barriered and prompting me to check this.

Change-Id: I57f80d0d918a529afdbf207abab51707288a3750
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/93188
Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Adam Langley <agl@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
1 file changed
tree: 51d55b7aa421f7e9fd56ff18bdf5e5adbe11f9fc
  1. .bcr/
  2. .github/
  3. bench/
  4. cmake/
  5. crypto/
  6. decrepit/
  7. docs/
  8. fuzz/
  9. gen/
  10. include/
  11. infra/
  12. pki/
  13. rust/
  14. ssl/
  15. third_party/
  16. tool/
  17. util/
  18. .bazelignore
  19. .bazelrc
  20. .bazelversion
  21. .clang-format
  22. .clang-format-ignore
  23. .gitattributes
  24. .gitignore
  25. API-CONVENTIONS.md
  26. AUTHORS
  27. BREAKING-CHANGES.md
  28. BUILD.bazel
  29. build.json
  30. BUILDING.md
  31. CMakeLists.txt
  32. codereview.settings
  33. CONTRIBUTING.md
  34. FUZZING.md
  35. go.mod
  36. go.sum
  37. INCORPORATING.md
  38. LICENSE
  39. MODULE.bazel
  40. MODULE.bazel.lock
  41. PORTING.md
  42. PRESUBMIT.py
  43. PrivacyInfo.xcprivacy
  44. README.md
  45. SANDBOXING.md
  46. SECURITY.md
  47. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: