| commit | 4cce955d1487b5bd2b3c03ead986558649cdaadf | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Thu Dec 13 12:20:54 2018 -0600 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Thu Dec 13 19:30:49 2018 +0000 |
| tree | 4961944cd076d1d5cb1fd018aef3b712abf04319 | |
| parent | 200fe6786b820414444615bb6c2bb09fce90b6c3 [diff] |
Fix thread-safety bug in SSL_get_peer_cert_chain. https://boringssl-review.googlesource.com/12704 pushed it just too far to the edge. Once we have an established SSL_SESSION, any modifications need to either be locked or done ahead of time. Do it ahead of time. session->is_server gives a suitable place to check and X509s are ref-counted so this should be cheap. Add a regression test via TSan. Confirmed that TSan indeed catches this. Change-Id: I30ce7b757d3a44465b318af3c98961ff3667483e Reviewed-on: https://boringssl-review.googlesource.com/c/33606 Commit-Queue: Adam Langley <agl@google.com> Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: