commit 97dc33638b40a428ce666d61d71ee3db08083bf3
author David Benjamin <davidben@google.com> Fri Jan 26 11:16:21 2024 -0500
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 26 18:18:38 2024 +0000
tree 88251e9b79433195c8ccda4bc095358b6a0fe330
parent 12316ab445eef5317391a94bef733fa6ff175173

Fix SHA ABI tests

Some 'return' lines snuck in which cause us to skip some tests.

Change-Id: I2806d6fb4fe3a6bd1fa58932c213d6af8991352e
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/65827
Reviewed-by: Bob Beck <bbe@google.com>
Commit-Queue: David Benjamin <davidben@google.com>

crypto/fipsmodule/sha/sha_test.cc

diff --git a/crypto/fipsmodule/sha/sha_test.cc b/crypto/fipsmodule/sha/sha_test.cc
index 671c170..5624288 100644
--- a/crypto/fipsmodule/sha/sha_test.cc
+++ b/crypto/fipsmodule/sha/sha_test.cc
@@ -66,13 +66,11 @@
 #if defined(SHA1_ASM_AVX)
     if (sha1_avx_capable()) {
       CHECK_ABI(sha1_block_data_order_avx, ctx.h, kBuf, blocks);
-      return;
     }
 #endif
 #if defined(SHA1_ASM_SSSE3)
     if (sha1_ssse3_capable()) {
       CHECK_ABI(sha1_block_data_order_ssse3, ctx.h, kBuf, blocks);
-      return;
     }
 #endif
 #if defined(SHA1_ASM_NEON)
@@ -103,13 +101,11 @@
 #if defined(SHA256_ASM_AVX)
     if (sha256_avx_capable()) {
       CHECK_ABI(sha256_block_data_order_avx, ctx.h, kBuf, blocks);
-      return;
     }
 #endif
 #if defined(SHA256_ASM_SSSE3)
     if (sha256_ssse3_capable()) {
       CHECK_ABI(sha256_block_data_order_ssse3, ctx.h, kBuf, blocks);
-      return;
     }
 #endif
 #if defined(SHA256_ASM_NEON)