Make constant-sized calls to Span::first/last/subspan compile-time sized.

This uses the newly added first<N>, last<N> and subspan<S, N> methods.

Also, changed subspan<0, N> to first<N> when it could be shown that the
input span has at least N elements based on checks/asserts before it.
This makes the return type compile-time sized even if the input span is
not.

NOT doing thsis however if:

- The span is only used within the same function in a simple scope with
  no chance for errors compile-time checks would catch
- The span is only passed to other functions or returned in cases where
  obviously the span has to be runtime sized (like if calling through a
  function pointer or returning as a return value)
- The span is runtime-sized based on a runtime-sized function argument
  or other data source that can't feasibly be made statically sized

Tested: IDA/Diaphora and ghidriff find no differences in generated code
other than type identifiers with the extra template argument.

Change-Id: I0eb52abd88f9f55a6651ddc333767e4e9345c03f
Bug: 390229582
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/82887
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
8 files changed
tree: 958dbb94cc140dc4d972c560a6679e969113a19e
  1. .bcr/
  2. .github/
  3. cmake/
  4. crypto/
  5. decrepit/
  6. docs/
  7. fuzz/
  8. gen/
  9. include/
  10. infra/
  11. pki/
  12. rust/
  13. ssl/
  14. third_party/
  15. tool/
  16. util/
  17. .bazelignore
  18. .bazelrc
  19. .bazelversion
  20. .clang-format
  21. .gitignore
  22. API-CONVENTIONS.md
  23. AUTHORS
  24. BREAKING-CHANGES.md
  25. BUILD.bazel
  26. build.json
  27. BUILDING.md
  28. CMakeLists.txt
  29. codereview.settings
  30. CONTRIBUTING.md
  31. FUZZING.md
  32. go.mod
  33. go.sum
  34. INCORPORATING.md
  35. LICENSE
  36. MODULE.bazel
  37. MODULE.bazel.lock
  38. PORTING.md
  39. PRESUBMIT.py
  40. PrivacyInfo.xcprivacy
  41. README.md
  42. SANDBOXING.md
  43. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: