commit 90b216937228807d14201f875e1e840e77aa3271
author David Benjamin <davidben@google.com> Wed Nov 27 11:36:25 2024 -0500
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Dec 05 18:54:15 2024 +0000
tree 09c213b0591c8fb37b4af4355716ea28f4ac8105
parent 484c3340e09fe99ddce41cb3ec7ea3fba6457bd6

Print the OS error when bssl_shim hits SSL_ERROR_SYSCALL

I was getting some mysterious CQ failures with SSL_ERROR_SYSCALL. This
made debugging easier and seems generally useful.

Change-Id: I201f886e7e0e0e6d92845a72057d38327da020a5
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/73649
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: David Benjamin <davidben@google.com>

ssl/test/bssl_shim.cc

diff --git a/ssl/test/bssl_shim.cc b/ssl/test/bssl_shim.cc
index aada04f..fda853c 100644
--- a/ssl/test/bssl_shim.cc
+++ b/ssl/test/bssl_shim.cc
@@ -960,6 +960,9 @@
     int ssl_err = SSL_get_error(ssl.get(), -1);
     if (ssl_err != SSL_ERROR_NONE) {
       fprintf(stderr, "SSL error: %s\n", SSL_error_description(ssl_err));
+      if (ssl_err == SSL_ERROR_SYSCALL) {
+        PrintSocketError("OS error");
+      }
     }
     return false;
   }