)]}'
{
  "commit": "8ede9514dac7cace2084d95502d4bd8ea39b08b6",
  "tree": "676fb94fa5df66e9bfed7cc2358c3edba91c2eb4",
  "parents": [
    "044fbc86ef5505d5fdab2befd476992ad1074665"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Sun Mar 17 15:29:54 2024 +1000"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Mar 19 01:42:31 2024 +0000"
  },
  "message": "Make EVP_PKEY_type into the identity function\n\nThis function exists because callers sometimes write\nEVP_PKEY_type(EVP_PKEY_id(pkey)), which is equivalent to\nEVP_PKEY_base_id(pkey).\n\nIn OpenSSL, all this existed so that a type parsed as EVP_PKEY_RSA2\ncould still be mapped to EVP_PKEY_RSA. We haven\u0027t supported this since\n2015, so this purely exists as a way to check that the key type exists.\nIn doing so, it currently pulls in the full implementation of every key\ntype.\n\nI could replicate the list of keys, but that is one more place we have\nto keep things up-to-date. Instead, just make this function the\nidentity. Looking through callers, it did not appear anyone depended on\nthe error condition.\n\nUpdate-Note: EVP_PKEY_type used to return NID_undef when given a garbage\nkey type. Given it is only ever used in concert with EVP_PKEY_id, this\nis unlikely to impact anyone. If it does, we can do the more tedious\noption.\n\nBug: 497\nChange-Id: Ibf68a07ef6906398df0fec425c869c107b8c90f4\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/67109\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9ccf2b7226b170150604d49adf7f563fb47bdcb9",
      "old_mode": 33188,
      "old_path": "crypto/evp/evp.c",
      "new_id": "3eefb526c47aafc9496751d5c383dc25071d1ba5",
      "new_mode": 33188,
      "new_path": "crypto/evp/evp.c"
    },
    {
      "type": "modify",
      "old_id": "8a9d6201246bdbc215dffb79a029d3d3deb84770",
      "old_mode": 33188,
      "old_path": "include/openssl/evp.h",
      "new_id": "93b2eb38dd2fb7bfd7ac79b98a860aff8b78ec03",
      "new_mode": 33188,
      "new_path": "include/openssl/evp.h"
    }
  ]
}
