)]}'
{
  "commit": "8e16c046b138e4806e69f22810b4d33e925ec58f",
  "tree": "385fa65ed64673713f25c250d022c895e2f4c36e",
  "parents": [
    "3f680b0eff18ddd6c878b92bffbc1b53fe6bd797"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Thu Jun 08 11:03:59 2023 -0400"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Jun 08 15:25:49 2023 +0000"
  },
  "message": "Avoid another NULL+0 in BIO_s_mem\n\nThat NULL+0 is forbidden is still an awful language bug in C (fixed in\nC++), but this particular instance could have been written without\npointer arithmetic. While I\u0027m here, tidy pointers a bit:\n\n- No need to cast pointers to char* when we\u0027re writing to void* anyway\n\n- BIO_C_GET_BUF_MEM_PTR is technically a strict aliasing violation. The\n  pointer points to a BUF_MEM*, not a char*, so we should not write to\n  it as a char**.\n\n- C casts from void* freely and we\u0027ve usually omitted the cast in that\n  case. (Though if we ever move libcrypto to C++, that\u0027ll all have to\n  change.)\n\nBug: b:286384999\nChange-Id: I16d7da675d61f726f259fc9a3cc4a6fce2d6d1fd\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/60605\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\nCommit-Queue: Bob Beck \u003cbbe@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1ee148b074b092f8c2146812068c3bd59cb65305",
      "old_mode": 33188,
      "old_path": "crypto/bio/bio_mem.c",
      "new_id": "5d7534c249ad38a291851ec40c7711d3c103e719",
      "new_mode": 33188,
      "new_path": "crypto/bio/bio_mem.c"
    },
    {
      "type": "modify",
      "old_id": "6610be9a28d405a67b5d54b520eb6f350be24dfb",
      "old_mode": 33188,
      "old_path": "crypto/bio/bio_test.cc",
      "new_id": "8827ce61411236f89c2394d0a489a7c67812872c",
      "new_mode": 33188,
      "new_path": "crypto/bio/bio_test.cc"
    }
  ]
}