)]}' { "commit": "8a58933db02f5059202709807562bae0d6633fdb", "tree": "0f442b4aed457b2dfc41fe41075e4303237f61ef", "parents": [ "0abd6f2eb6eeb1a780f9f37bcdc4ebf5298d8cb8" ], "author": { "name": "David Benjamin", "email": "davidben@chromium.org", "time": "Fri Dec 04 23:14:35 2015 -0500" }, "committer": { "name": "Adam Langley", "email": "agl@google.com", "time": "Tue Dec 15 21:29:46 2015 +0000" }, "message": "Remove the CRYPTO_EX_new callback.\n\nThis callback is never used. The one caller I\u0027ve ever seen is in Android\ncode which isn\u0027t built with BoringSSL and it was a no-op.\n\nIt also doesn\u0027t actually make much sense. A callback cannot reasonably\nassume that it sees every, say, SSL_CTX created because the index may be\nregistered after the first SSL_CTX is created. Nor is there any point in\nan EX_DATA consumer in one file knowing about an SSL_CTX created in\ncompletely unrelated code.\n\nReplace all the pointers with a typedef to int*. This will ensure code\nwhich passes NULL or 0 continues to compile while breaking code which\npasses an actual function.\n\nThis simplifies some object creation functions which now needn\u0027t worry\nabout CRYPTO_new_ex_data failing. (Also avoids bouncing on the lock, but\nit\u0027s taking a read lock, so this doesn\u0027t really matter.)\n\nBUG\u003d391192\n\nChange-Id: I02893883c6fa8693682075b7b130aa538a0a1437\nReviewed-on: https://boringssl-review.googlesource.com/6625\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "5409a653bac76763932d1c83517d361dae8e2ecc", "old_mode": 33188, "old_path": "crypto/dh/dh.c", "new_id": "bf6196ceb2d3cd10392f3eac7f2d648148e90457", "new_mode": 33188, "new_path": "crypto/dh/dh.c" }, { "type": "modify", "old_id": "ceffd1ad37bacc390ef67cb7f69e1e8ac474d56f", "old_mode": 33188, "old_path": "crypto/dsa/dsa.c", "new_id": "5bf031e1878c9e642b47623304809157d07c1e3d", "new_mode": 33188, "new_path": "crypto/dsa/dsa.c" }, { "type": "modify", "old_id": "0a8036689431239d95bcddeeb269e3e37a735e4f", "old_mode": 33188, "old_path": "crypto/ec/ec_key.c", "new_id": "d3bf4c617db866c36abb8fc455dc7b2ba2eae09f", "new_mode": 33188, "new_path": "crypto/ec/ec_key.c" }, { "type": "modify", "old_id": "f562f17bb9926ca0cca3f72a472c44bd4107ff84", "old_mode": 33188, "old_path": "crypto/ex_data.c", "new_id": "31d4356115c0ce5fbd3439b0d74895188e9f4e4f", "new_mode": 33188, "new_path": "crypto/ex_data.c" }, { "type": "modify", "old_id": "ede8c2793f4c0086264ca6a38117595f560ee8fa", "old_mode": 33188, "old_path": "crypto/internal.h", "new_id": "bf45349eb2f755013bff083345488a9e135e2b54", "new_mode": 33188, "new_path": "crypto/internal.h" }, { "type": "modify", "old_id": "49ab27b730c177d743146a6d34b5b451e40d6efe", "old_mode": 33188, "old_path": "crypto/rsa/rsa.c", "new_id": "6c28ad76f28eedc7d160d99a6690538a9c02da9c", "new_mode": 33188, "new_path": "crypto/rsa/rsa.c" }, { "type": "modify", "old_id": "b15ebfed81eddeb5424660c8501f9fb63ac82271", "old_mode": 33188, "old_path": "crypto/x509/x509_vfy.c", "new_id": "ba5885c5503e80d10b569457ae445ba768f26093", "new_mode": 33188, "new_path": "crypto/x509/x509_vfy.c" }, { "type": "modify", "old_id": "b8f318a0436378e6655cfa518ce935a28742602d", "old_mode": 33188, "old_path": "crypto/x509/x_x509.c", "new_id": "7bbe4f3606c81d3e6119ce4d6064018c4148afef", "new_mode": 33188, "new_path": "crypto/x509/x_x509.c" }, { "type": "modify", "old_id": "d781789e64f5ab8c9b4b5ca5ede5c4a94c202bb5", "old_mode": 33188, "old_path": "include/openssl/dh.h", "new_id": "2c49fc8349cb179019073df839285d23ec972a65", "new_mode": 33188, "new_path": "include/openssl/dh.h" }, { "type": "modify", "old_id": "bd1639505a42bda820cff6f6e441de81181087d4", "old_mode": 33188, "old_path": "include/openssl/dsa.h", "new_id": "2045fe736de666500e6a7745fa775532a127d234", "new_mode": 33188, "new_path": "include/openssl/dsa.h" }, { "type": "modify", "old_id": "5226796aa8bb797d3369612b2e2c791c8e6eaf30", "old_mode": 33188, "old_path": "include/openssl/ec_key.h", "new_id": "afd95d6a196414ddd65c247a18cbc56e88853ab2", "new_mode": 33188, "new_path": "include/openssl/ec_key.h" }, { "type": "modify", "old_id": "c0d3773165786c88ed1fc9e0917d546e2f63ffa7", "old_mode": 33188, "old_path": "include/openssl/ex_data.h", "new_id": "0e88c0f00692584acf951f5c0248affde9cc1576", "new_mode": 33188, "new_path": "include/openssl/ex_data.h" }, { "type": "modify", "old_id": "e624f7ca2d20ddbabcd804f8c24a178b95f05d4f", "old_mode": 33188, "old_path": "include/openssl/rsa.h", "new_id": "7f8cfe38885263d5f9221027919a1d747a7e1785", "new_mode": 33188, "new_path": "include/openssl/rsa.h" }, { "type": "modify", "old_id": "b61df9d0c639981ce0a499dd41d824b7c80aeb8f", "old_mode": 33188, "old_path": "include/openssl/ssl.h", "new_id": "885dea205e88c00ed6b9e59c6fd9b47a2a9acb3f", "new_mode": 33188, "new_path": "include/openssl/ssl.h" }, { "type": "modify", "old_id": "da569e893f952f8ffb31bcea93b5b7213c52c180", "old_mode": 33188, "old_path": "include/openssl/x509.h", "new_id": "483c5de1eae410ab580fda0a087b4631ea93b7df", "new_mode": 33188, "new_path": "include/openssl/x509.h" }, { "type": "modify", "old_id": "c11820b461061f8704ace1b5a801784115209fb1", "old_mode": 33188, "old_path": "include/openssl/x509_vfy.h", "new_id": "b39ef49c97d9ab528b10f93c25b522f9e315c3f8", "new_mode": 33188, "new_path": "include/openssl/x509_vfy.h" }, { "type": "modify", "old_id": "5e4d99751e7292ef4adfb1360ab0d5b9913a2902", "old_mode": 33188, "old_path": "ssl/ssl_lib.c", "new_id": "c65e607c1c7bb2f480eb6b5273454aaccb85426a", "new_mode": 33188, "new_path": "ssl/ssl_lib.c" }, { "type": "modify", "old_id": "ead0b7531f5b41393500733557fbf48f56fca994", "old_mode": 33188, "old_path": "ssl/ssl_session.c", "new_id": "0dcfdd89f5930c784c4c7fa34f5871dafc73b5fb", "new_mode": 33188, "new_path": "ssl/ssl_session.c" } ] }