tree 9b88160c951f804e7074e274f31e42ce4bffa6b2
parent d707bc026f9a043ae14e87cec3ccdcb50b7a16a8
author David Benjamin <davidben@google.com> 1614309625 -0500
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1614364356 +0000

Define X509V*_VERSION constants.

The X509 version APIs confuse everyone, including our own tests
(v3name_test.cc was using the wrong value). Introduce constants. Also
document which version to use for each type. It is extra confusing that,
although certificates and CRLs use the same Version enum, RFC5280
defines X.509 v3 certificates with X.509 v2 CRLs. (There are no v3
CRLs.)

I'll send a similar patch to OpenSSL to keep upstream aligned.

Change-Id: If096138eb004156d43df87a6d74f695b04f67480
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/45944
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>