)]}' { "commit": "898de8d09e10960e64901e2d9836cdea5dd1d1a6", "tree": "552369ae1ba66c785b3c5d253ef11e7324d978fa", "parents": [ "173b63942dd0c58a67a354dbb4b86c6f752aac6a" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Sat Mar 11 12:26:37 2023 -0500" }, "committer": { "name": "Boringssl LUCI CQ", "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 16 23:46:11 2023 +0000" }, "message": "Rewrite c2i_ASN1_OBJECT\n\nRemoving object reuse makes it dramatically simpler. Along the way, lift\nthe OID validity checker into crypto/bytestring, so we can use it more\ngenerally. (Although the difference between invalid OID and unknown OID\nis pretty academic, so this check isn\u0027t that important.)\n\nFor now I\u0027ve preserved the existing behavior, where the OID validity\nchecker accepts arbitrarily large OID components. Though this results in\nan oddity where the OID to string functions reject inputs that the\nparser accepts. (There we only allow up to 2^64-1.)\n\nUpdate-Note: When we removed object-reuse from all the d2i functions, we\nmissed one d2i_ASN1_OBJECT. See\nhttps://boringssl-review.googlesource.com/c/boringssl/+/56647.\nOtherwise, this CL is not expected to change behavior.\n\nChange-Id: If4d2d83d9f3c96abfdc268e156f2cf3a9a903b0c\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/58147\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "55b6dadb018fb04165b22a8483e4943626e7f039", "old_mode": 33188, "old_path": "crypto/asn1/a_object.c", "new_id": "e50193413576a1bf17ff48698189d74af3d6925d", "new_mode": 33188, "new_path": "crypto/asn1/a_object.c" }, { "type": "modify", "old_id": "ca22c41c394602d983a7be3a2da7f33a774c8d5d", "old_mode": 33188, "old_path": "crypto/bytestring/bytestring_test.cc", "new_id": "10d34697a82678a974d62d3d1134ca80744416dd", "new_mode": 33188, "new_path": "crypto/bytestring/bytestring_test.cc" }, { "type": "modify", "old_id": "8f815863c6fcdf3d1732d5d92b0061023fd9822b", "old_mode": 33188, "old_path": "crypto/bytestring/cbs.c", "new_id": "eb7e4dc984e06a93a4f773fd7a9d26a167f8a0f8", "new_mode": 33188, "new_path": "crypto/bytestring/cbs.c" }, { "type": "modify", "old_id": "b6fdda83ea8f8ddb12fb38b400f2aa671bd10305", "old_mode": 33188, "old_path": "include/openssl/bytestring.h", "new_id": "33e13ef8ed76def2292d8ca8c0abb076ff6f3b69", "new_mode": 33188, "new_path": "include/openssl/bytestring.h" } ] }