commit | 89134daffd70531be70cdfdd14e9d0e00903fd3c | [log] [tgz] |
---|---|---|
author | David Benjamin <davidben@google.com> | Sun Feb 18 00:17:50 2024 -0500 |
committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Feb 26 22:08:59 2024 +0000 |
tree | 22777085a3dbfcc3ff101614ba39608dfdd2255e | |
parent | db614a5677d90e48cfb2c0f8197f1b5168fceea5 [diff] |
Test X509_verify_cert with CAs that share a name In that case, we rely on AKID/SKID matches to disambiguate. However, OpenSSL's internal interfaces are not very good at handling this case and often work around their own bugs. As a precursor to, hopefully, cleaning that up someday, test this, with both direct adding and hash_dir. I've just tested the basic case here. Looking at the code, I think there are bugs where, e.g., if CA1 was added directly and CA2 is only accessible via hash_dir, X509_STORE_CTX_get1_issuer does not know to check hash_dir for CA2, because internal interfaces get in the way. Bug: 685 Change-Id: I32737661c84d6a006cf9d5ae1ec42b3f27437bf0 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/66010 Reviewed-by: Bob Beck <bbe@google.com> Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: